Repository navigation
chore: update ComfyUI to v0.44.0 and flake inputs - #119
Merged
Merged
Conversation
Member
Author
|
CUDA verification on hal9000 (RTX 4090, driver 595.71.05,
|
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.37.0->v0.44.0, with the vendored wheels pinned to exactly what v0.44.0'srequirements.txtrequires:1.52.7->1.57.60.11.66->0.11.101(core0.3.392, JSON0.1.127, media assets 010.1.48, media assets 020.1.27)0.5.12->0.5.160.2.35->0.2.400.5.5->0.6.0test_cwe_404.py::test_standalone_pipeline. It hit pytest-timeout under sandbox load and failed the whole build via narwhals' check inputs. The macOS port isolation is kept behindisDarwin.opensslto the check inputs. Inductor's codecache shells out toopenssl; nixpkgs' torch patches in a store path, but the CUDA/ROCm/XPU wheels look it up onPATH. This brokeextra-python-packages-cuda.Testing
nix flake checkpasses locally (x86_64-linux)../data:model_downloaderroutes register.POST /model-downloader/download, TAESD 9.8 MB) completed and shows up in/models/vae_approx.<a download>click was intercepted and sent to the backend. The download completed and the Model Downloads widget shows "Complete".Not covered / follow-ups
0.6.0(CUDA memory management) has not been exercised.Unknown message type model_download_progress. This is not a regression; 1.57.6 just logs at a higher level.model_downloader.jsregisters throughwindow.api, which no current frontend defines, so progress arrives only through the WebSocket fallback. A follow-up should switch it toimport { api } from "../../scripts/api.js".torchaudiofromrequirements.txt. It is still packaged here./extensions/core/clipspace.js. This already happened on frontend 1.52.7.opensslonPATHat runtime fortorch.compile. This predates the PR and should be checked in the launcher.