Repository navigation
refactor: list torchaudio as a custom-node dependency - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121.
Upstream ComfyUI dropped torchaudio in Comfy-Org/ComfyUI#16457; v0.44.0 has no references to it. It still ships here only because two bundled custom nodes import it: ComfyUI-MMAudio and ComfyUI-WanVideoWrapper.
Change
nix/packages.nix: torchaudio moves out of the core torch block (optionals) and into the custom-node dependency section (extras), with a comment naming the two nodes and the upstream removal.nix/custom-nodes.nix: torchaudio is added to both nodes'passthru.pythonDeps.Not a closure change
The Python environment is fixed at build time and always includes the bundled nodes.
bundledCustomNodes = falseonly skips the runtime symlinks. So torchaudio is still shipped, and the package contents are the same. This PR records why it is there, so it can be dropped when those nodes stop needing it. Separately,passthru.pythonDepsisn't consumed anywhere today; node deps are listed by hand inpackages.nix. I updated both places so they stay consistent.Testing
nix build .#defaultand thenixfmtcheck pass.default,cuda,rocm72andxpu. macOS couldn't be checked; see below.Related, not fixed here
.#packages.aarch64-darwin.defaultfails to evaluate on main since #119's nixpkgs bump:Refusing to evaluate package 'python3.12-filterpy-2.0.0' … because it has problems. PR CI is Linux-only, so it didn't catch this. It will be tracked and fixed separately.