Repository navigation
fix(darwin): clear filterpy broken flag so macOS packages evaluate - #123
Merged
Merged
Conversation
Member
Author
|
Post-merge verification: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #119's nixpkgs bump, every
aarch64-darwinoutput failed to evaluate:nixpkgs now sets
meta.broken = stdenv.hostPlatform.isDarwinon filterpy ("last successful hydra build on darwin was in 2025"). Hydra fails in the test suite:test_hinfinityhits a BPT trap. Our override already disables filterpy's tests on Darwin for that exact reason, so it now also clearsmeta.broken. filterpy is pulled in by facexlib (PuLID).PR CI is Linux-only, so this was not caught.
Testing
nix flake check --no-build --all-systemsevaluates cleanly. It failed on main..#packages.aarch64-darwin.defaultbuilt on a real Apple Silicon Mac (bender): result posted below.