Skip to content

Configure models and guest-shopper instructions - #4319

Draft
Ji-One1 wants to merge 2 commits into
jb/storefront-e2e-v2-11-page-cart-readinessfrom
jb/storefront-e2e-v2-12-model-instructions
Draft

Ji-One1 wants to merge 2 commits into
jb/storefront-e2e-v2-11-page-cart-readinessfrom
jb/storefront-e2e-v2-12-model-instructions

Conversation

@Ji-One1

@Ji-One1 Ji-One1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

The buyer needs explicit model credentials and guest-shopper instructions. A provider key must not be sent to an unrelated provider merely because another environment variable is present.

What this changes

  • Define and validate model name, API key, optional base URL, and non-credential headers.
  • Resolve credentials in order: the explicit storefront-tool key/endpoint pair, a matching native provider key, then the known Shopify AI proxy endpoint for that provider.
  • Add the Shopify usage tag for proxy requests. Require HTTPS except for loopback HTTP, reject key line breaks, and reject credential-bearing header names.
  • Add guest instructions for visible UI actions, blocking overlays, optional-cookie rejection, early friction reports, and stopping after the requested action. They prohibit login, personal/payment details, purchases, and duplicate adds when the outcome is unclear.
  • After a blocked checkout navigation, instruct the buyer not to bypass the block or retry checkout. If the objective is unfinished, return through visible storefront UI if needed (browser Back is allowed) and continue; otherwise finish. This is an instruction, not a guarantee of model recovery.
  • If a checkout page actually loads, or a page asks for login, personal, contact, address, or payment details, instruct the buyer not to interact: report friction and finish.

Developer impact

Internal tooling only; no published Hydrogen changes or changeset. These are configuration and prompt helpers. This PR does not yet attach a model or run a buyer.

Risk

The operator owns the explicit generic key/endpoint pairing. Instructions alone are not a security boundary. Endpoint validation and fixed validation messages do not provide artifact redaction.

Stack: 11/15. Previous: #4318. Next: #4320.

@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from e0a3546 to 551f4af Compare November 5, 2026 16:23
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch 2 times, most recently from 2f7f777 to e272579 Compare November 5, 2026 18:42
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 551f4af to 332bfb8 Compare November 5, 2026 18:42
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch from e272579 to ae3da56 Compare November 6, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch 2 times, most recently from 74e1f21 to 8f61b9c Compare November 6, 2026 01:36
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch 2 times, most recently from 625b6b8 to afaa6fb Compare November 6, 2026 01:45
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 2caa429 to 5fe5a5f Compare November 6, 2026 14:27
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch 2 times, most recently from 36121b3 to 4cc83cb Compare November 6, 2026 15:08
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 5fe5a5f to 4303447 Compare November 6, 2026 15:08
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch from 4cc83cb to b67a4d2 Compare November 6, 2026 16:20
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 4303447 to 6fe9f2b Compare November 6, 2026 16:20
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 6fe9f2b to 66f4b1d Compare November 6, 2026 19:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch from b67a4d2 to 27d2151 Compare November 6, 2026 19:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 66f4b1d to ecf1fa3 Compare November 6, 2026 20:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch from 27d2151 to 2b8b89d Compare November 6, 2026 20:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from ecf1fa3 to e1081d6 Compare November 6, 2026 20:32
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch from 2b8b89d to 863a3fb Compare November 6, 2026 20:32
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from e1081d6 to 835920f Compare November 6, 2026 20:59
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch from 863a3fb to 065af23 Compare November 6, 2026 20:59
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 835920f to 88cc2ae Compare November 9, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch from 065af23 to 069f70d Compare November 9, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 88cc2ae to c05ee80 Compare November 9, 2026 00:37
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch 2 times, most recently from b49fa33 to e92da17 Compare November 9, 2026 04:23
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-11-page-cart-readiness branch from 27b327d to bb59481 Compare November 9, 2026 06:55
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-12-model-instructions branch from e92da17 to 6e7de57 Compare November 9, 2026 06:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant