Skip to content

Run bounded storefront scenarios - #4314

Draft
Ji-One1 wants to merge 2 commits into
jb/storefront-e2e-v2-06-add-assertionfrom
jb/storefront-e2e-v2-07-runner
Draft

Ji-One1 wants to merge 2 commits into
jb/storefront-e2e-v2-06-add-assertionfrom
jb/storefront-e2e-v2-07-runner

Conversation

@Ji-One1

@Ji-One1 Ji-One1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

The scenario needs one owner for execution order, deadlines, and cleanup. Browser or buyer failures must not become false storefront failures.

What this changes

  • Add a driver-based runner: open the storefront, record configured context, prepare the scenario, open its same-origin start page, create the buyer, and run checkpoints.
  • Pass the scenario's selected Standard Events to the driver. Skipped preparation creates no buyer and makes no model call.
  • Fail a pinned product route that returns HTTP 404 or 410 without a redirect. Other load problems remain inconclusive.
  • Keep checkout evidence diagnostic: it does not abort the buyer. Step limits, run deadlines, and external cancellation still apply.
  • Detach the buyer before the final checkpoint assertion and after an abort, error, or step limit. Keep a buyer whose earlier run ended with reason completed for the next checkpoint.
  • Always offer the configured driver cart reader to assertions, regardless of checkout evidence. A missing driver reader remains unavailable; an unreadable page can still make a cart read fail.
  • Bound assertions and cleanup, handle late-created sessions, append evidence in order, and write the final result. Cleanup and evidence-write problems are warnings; an unconfirmed required detach prevents a conclusive verdict.

Developer impact

Internal tooling only; no published Hydrogen changes or changeset. The runner accepts driver factories but does not yet supply a concrete browser/buyer driver or CLI.

Risk

Country and language remain configured-only values. Cleanup deadlines can leave work unfinished. Artifact write failures can prevent a complete saved report; result writing itself can reject. Private evidence is not redacted.

Stack: 06/15. Previous: #4313. Next: #4315.

@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch from 1439504 to f2f047a Compare November 5, 2026 16:23
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch from 96d33e8 to 8993b83 Compare November 5, 2026 18:42
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch from f2f047a to 03701d2 Compare November 5, 2026 18:42
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch from 8993b83 to ef675fd Compare November 6, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch from 03701d2 to 7f76fac Compare November 6, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch from ef675fd to e5297a7 Compare November 6, 2026 01:36
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch 2 times, most recently from b6be856 to 8aa8b58 Compare November 6, 2026 01:45
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch 2 times, most recently from 757c15b to 1b63035 Compare November 6, 2026 14:27
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch 2 times, most recently from 5273481 to c29bd08 Compare November 6, 2026 15:08
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch 2 times, most recently from 3a5d4ff to 9f63be1 Compare November 6, 2026 16:20
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch from c29bd08 to 6148013 Compare November 6, 2026 16:20
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch 2 times, most recently from c5de305 to e3083bc Compare November 6, 2026 20:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch from 0caec02 to 82d9bf1 Compare November 6, 2026 20:32
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch 2 times, most recently from 0a786a1 to 51667bd Compare November 9, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch from 82d9bf1 to 1de4e2c Compare November 9, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch from 51667bd to 70d499a Compare November 9, 2026 00:37
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch from 1de4e2c to 6958252 Compare November 9, 2026 00:37
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch from 70d499a to 5c92ce6 Compare November 9, 2026 04:23
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch from 6958252 to 4626db0 Compare November 9, 2026 04:23
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-06-add-assertion branch from 4626db0 to c348e93 Compare November 9, 2026 06:55
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-07-runner branch from 5c92ce6 to 27ef4b3 Compare November 9, 2026 06:55

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant