Repository navigation
Conversation
This was referenced Nov 5, 2026
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 5, 2026 16:23
d5219d3 to
5e226d3
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 5, 2026 16:23
e0a3546 to
551f4af
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 5, 2026 18:42
5e226d3 to
98de12f
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
2 times, most recently
from
November 6, 2026 00:01
332bfb8 to
74e1f21
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 6, 2026 00:01
98de12f to
576904c
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 6, 2026 01:36
74e1f21 to
8f61b9c
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
2 times, most recently
from
November 6, 2026 01:45
734359c to
900b21b
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 6, 2026 01:45
8f61b9c to
2caa429
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 6, 2026 14:27
900b21b to
5e3daad
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 6, 2026 14:27
2caa429 to
5fe5a5f
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 6, 2026 15:08
5e3daad to
9d1ffc1
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 6, 2026 15:08
5fe5a5f to
4303447
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 6, 2026 16:20
4303447 to
6fe9f2b
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
2 times, most recently
from
November 6, 2026 19:01
5f3c634 to
731ec61
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
2 times, most recently
from
November 6, 2026 20:01
66f4b1d to
ecf1fa3
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 6, 2026 20:01
731ec61 to
5bb49ea
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 6, 2026 20:32
ecf1fa3 to
e1081d6
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
2 times, most recently
from
November 6, 2026 20:59
77a741f to
9e8c131
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 6, 2026 20:59
e1081d6 to
835920f
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 9, 2026 00:01
9e8c131 to
d75930e
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 9, 2026 00:01
835920f to
88cc2ae
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 9, 2026 00:37
d75930e to
b5f4e39
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 9, 2026 00:37
88cc2ae to
c05ee80
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 9, 2026 04:23
b5f4e39 to
6ecdbef
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 9, 2026 04:23
c05ee80 to
27b327d
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-10-browser-lifecycle
branch
from
November 9, 2026 06:55
6ecdbef to
d2b9663
Compare
Ji-One1
force-pushed
the
jb/storefront-e2e-v2-11-page-cart-readiness
branch
from
November 9, 2026 06:55
27b327d to
bb59481
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buyer needs an observable page, and the assertion needs the active cart from that same browser session. These helpers provide both without using page text as cart proof.
What this changes
GET <root>cart.jsin the page with the session's own cookies. Hydrogen rewrites this AJAX endpoint to upstreamcart.json.window.Shopify.routes.root, or the supplied storefront base path. Refuse unsupported roots and redirects; request no cache and bound the fetch, including the body, to five seconds.CartReadErrorcodes defined earlier.Developer impact
Internal tooling only; no published Hydrogen changes or changeset. No cookie is read, parsed, or set by the reader. No cart ID or Storefront API cart query is needed.
Risk
Readiness does not prove network idle, stable UI, or iframe registration. A custom storefront might serve a cart different from its UI cart at this endpoint; the helper cannot detect that. Buyer integration and CLI wiring are separate.
Stack: 10/15. Previous: #4317. Next: #4319.