Skip to content

Classify checkout navigation evidence - #4312

Closed
Ji-One1 wants to merge 6 commits into
jb/storefront-e2e-v2-04-standard-eventsfrom
jb/storefront-e2e-v2-05-cart-identity
Closed

Ji-One1 wants to merge 6 commits into
jb/storefront-e2e-v2-04-standard-eventsfrom
jb/storefront-e2e-v2-05-cart-identity

Conversation

@Ji-One1

@Ji-One1 Ji-One1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

The runner needs a shared rule for when checkout evidence must stop the buyer. A blocked embedded checkout widget must not count as the shopper leaving for checkout.

What this changes

  • Add isCheckoutHandoff for captured checkout records and blocked checkout navigation.
  • Exclude blocked requests marked embedded.
  • Treat blocked checkout requests with a missing or unknown frame type as handoffs, so uncertainty takes the safer path.

Developer impact

This is an internal evidence classifier. It adds no browser interception, cart lookup, URL parsing, or executable flow. No published Hydrogen changes or changeset.

Risk

Incomplete frame metadata can stop a buyer even when the request came from an embedded frame. This is intentional.

Stack: 05/16. Previous: #4311. Next: #4313.

@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-05-cart-identity branch from f66f9b3 to e4c1268 Compare November 5, 2026 16:23
@Ji-One1 Ji-One1 changed the title Read and bind API cart identities Read API carts and redact checkout evidence Nov 5, 2026
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-04-standard-events branch from 49c7b24 to 67d149e Compare November 5, 2026 18:42
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-05-cart-identity branch 3 times, most recently from f7e0005 to a6b1a4f Compare November 6, 2026 01:36
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-04-standard-events branch 2 times, most recently from 3d68c1c to 9160988 Compare November 6, 2026 01:45
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-05-cart-identity branch 2 times, most recently from 22fa039 to 7a6ae96 Compare November 6, 2026 14:27
@Ji-One1 Ji-One1 changed the title Read API carts and redact checkout evidence Redact checkout and cart evidence Nov 6, 2026
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-04-standard-events branch from 159401b to 2d1d3dc Compare November 6, 2026 15:08
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-05-cart-identity branch 2 times, most recently from 13e6688 to 1f1749c Compare November 6, 2026 16:20
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-04-standard-events branch from 2d1d3dc to 3cefe90 Compare November 6, 2026 16:20
@Ji-One1 Ji-One1 changed the title Redact checkout and cart evidence Classify checkout navigation evidence Nov 6, 2026
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-05-cart-identity branch 4 times, most recently from d94d8f0 to a6cd510 Compare November 9, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-04-standard-events branch from 04de19b to 961f2fb Compare November 9, 2026 00:01
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-05-cart-identity branch from a6cd510 to 4daf6f6 Compare November 9, 2026 00:37
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-04-standard-events branch from 961f2fb to 2c0dc91 Compare November 9, 2026 00:37
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-05-cart-identity branch from 4daf6f6 to 975536f Compare November 9, 2026 04:23
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-04-standard-events branch from 2c0dc91 to 949c6cb Compare November 9, 2026 04:24
@Ji-One1
Ji-One1 marked this pull request as ready for review November 9, 2026 06:21
@Ji-One1
Ji-One1 requested a review from a team as a code owner November 9, 2026 06:21
@Ji-One1
Ji-One1 force-pushed the jb/storefront-e2e-v2-04-standard-events branch from 949c6cb to d5aa3fe Compare November 9, 2026 06:55
@Ji-One1

Ji-One1 commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this PR because its checkout-handoff classifier has been removed. The rewritten runner no longer stops the buyer automatically when checkout evidence arrives. Checkout navigation protection remains in #4315 and #4317, including browser interception and diagnostic capture. The new 15-PR stack bypasses #4312: #4313 now follows #4311.

@Ji-One1 Ji-One1 closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant