Skip to content

Merge interim hourly weather into forecast slot icons - #2

Merged
yeled merged 1 commit into
mainfrom
interim-weather-merge
Jun 24, 2026
Merged

yeled merged 1 commit into
mainfrom
interim-weather-merge

Conversation

@yeled

@yeled yeled commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Each 8am/12pm/4pm/8pm forecast slot previously sampled only its exact hour, so a shower falling between two slots never showed up in the icon.
  • Slots now scan their whole window (up to the next slot) and render whichever hour is most significant — ranked by precipitation severity (thunder > heavy rain > snow shower > snow > sleet > rain > drizzle > fog > mist), falling back to the cloudiest hour otherwise.
  • Documented the new behavior in a "Forecast slots" section in the README.

Test plan

  • Unit-checked _hour_cell with synthetic hourly data containing rain only at 10am — confirms the 8am slot now reports "Rain" instead of "Partly cloudy".
  • Fetched real Open-Meteo data for London on 2026-06-22 (drizzle at 10–11pm) and rendered the full layout — 8pm slot now shows "Light drizzle" instead of "Overcast".
  • Ran a normal live preview (--png) to confirm layout/rendering is unaffected when there's no interim weather to merge.

🤖 Generated with Claude Code

Each 8am/12pm/4pm/8pm slot previously sampled only its exact hour, so
rain falling between two slots never showed up. Slots now scan their
whole window and use the most significant hour (by precipitation
severity, falling back to cloudiest) so interim showers are reflected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@yeled yeled mentioned this pull request Jun 24, 2026
2 tasks done
@yeled
yeled merged commit 648ccc1 into main Jun 24, 2026
2 checks passed
@yeled
yeled deleted the interim-weather-merge branch June 24, 2026 05:26
@yeled yeled mentioned this pull request Jun 24, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant