Skip to content

Add 4 more forecast slots (10am/2pm/6pm/10pm) - #3

Closed
yeled wants to merge 2 commits into
interim-weather-mergefrom
more-forecast-icons
Closed

yeled wants to merge 2 commits into
interim-weather-mergefrom
more-forecast-icons

Conversation

@yeled

@yeled yeled commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • Expands the forecast row from 4 slots (every 4h) to 8 (every 2h: 8am-10pm), giving finer-grained coverage of interim weather.
  • 8 slots divide evenly into two full rows of 4 in the full layout's fixed 4-column grid — verified against real Open-Meteo data for 2026-06-22 (London), which also exercises the window-merge logic from the base branch (10pm slot picks up a drizzle shower).
  • --days now defaults to 1: a 2-day view at this density overlapped rows and clipped off the bottom of the 480px frame, since the grid CSS wasn't built for this many cells.
  • Stacked on interim-weather-merge (Merge interim hourly weather into forecast slot icons #2) since this builds directly on the window-merge work there.

Test plan

  • Rendered the full layout for 2026-06-22 with 8 slots / 1 day — two clean, evenly balanced rows of 4, no overlap or clipping.
  • Confirmed a 2-day render at this slot count overlaps rows and clips the bottom row (motivated the --days default change).

🤖 Generated with Claude Code

yeled and others added 2 commits June 24, 2026 06:09
Going from 4 slots (every 4h) to 7 (every 2h) gives a finer-grained
forecast, but 7 cells per day already wraps to two rows in the full
layout's fixed 4-column grid. A 2-day view at this density overlaps
rows and clips off the bottom of the 480px frame, so --days now
defaults to 1 until the grid is reworked for the higher column count.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Rounds 7 slots out to 8, which divides evenly into two full rows in
the full layout's 4-column grid instead of an unbalanced 4+3 split.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@yeled
yeled deleted the branch interim-weather-merge June 24, 2026 05:26
@yeled yeled closed this Jun 24, 2026
@yeled yeled mentioned this pull request Jun 24, 2026
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant