Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#92](https://github.com/utensils/comfyui-nix/issues/92))

### Fixed
- macOS packages evaluate again. The nixpkgs update in #119 marks filterpy
broken on Darwin because its tests crash there; our override already skips
those tests, so it now also clears the broken flag. Without this, every
`aarch64-darwin` output failed with `Refusing to evaluate package
'python3.12-filterpy-2.0.0'`.
- The model downloader now subscribes to `model_download_progress` through
ComfyUI's API client (`window.comfyAPI.api.api`). It previously registered
only through the legacy `window.api`, which current frontends don't define,
Expand Down
8 changes: 7 additions & 1 deletion nix/python-overrides.nix
Original file line number Diff line number Diff line change
Expand Up @@ -1123,10 +1123,16 @@ lib.optionalAttrs useCuda {
});
}

# Disable filterpy tests on Darwin (test_hinfinity triggers BPT trap in pytest)
# Disable filterpy tests on Darwin (test_hinfinity triggers BPT trap in pytest).
# nixpkgs marks it broken on Darwin because Hydra's builds fail in those same
# tests ("last successful hydra build on darwin was in 2025"); with the tests
# skipped it builds, so clear the flag. facexlib (PuLID) depends on it.
// lib.optionalAttrs (prev ? filterpy) {
filterpy = prev.filterpy.overridePythonAttrs (old: {
doCheck = if pkgs.stdenv.hostPlatform.isDarwin then false else (old.doCheck or true);
meta = (old.meta or { }) // {
broken = false;
};
});
}

Expand Down
Loading