Skip to content

refactor: list torchaudio as a custom-node dependency #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesbrink merged 2 commits into from
Nov 12, 2026
Merged

refactor: list torchaudio as a custom-node dependency #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e6abf0
refactor: list torchaudio as a custom-node dependency
jamesbrink Nov 12, 2026
6c04851
Merge remote-tracking branch 'origin/main' into refactor/torchaudio-n…
jamesbrink Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#91](https://github.com/utensils/comfyui-nix/issues/91))

### Changed
- torchaudio is now listed as a dependency of the bundled ComfyUI-MMAudio and
ComfyUI-WanVideoWrapper nodes rather than of ComfyUI itself, since upstream
ComfyUI dropped it (Comfy-Org/ComfyUI#16457). It is still shipped while those
nodes are bundled, so the package contents are unchanged.
([#121](https://github.com/utensils/comfyui-nix/issues/121))
- Updated ComfyUI to upstream `v0.44.0` (from `v0.37.0`). Updated its pinned
dependencies: frontend `1.52.7` -> `1.57.6`, workflow templates `0.11.66`
-> `0.11.101` (core `0.3.357` -> `0.3.392`, JSON `0.1.92` -> `0.1.127`,
Expand Down
2 changes: 2 additions & 0 deletions nix/custom-nodes.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,7 @@ let
open-clip-torch
accelerate
ftfy
torchaudio
];

meta = with lib; {
Expand Down Expand Up @@ -430,6 +431,7 @@ let
opencv4
scipy
einops
torchaudio
];

meta = with lib; {
Expand Down
4 changes: 3 additions & 1 deletion nix/packages.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,9 @@ let
# PuLID dependencies
onnxruntime # ONNX runtime
]
# MMAudio + WanVideoWrapper dependency. Upstream ComfyUI dropped torchaudio
# (Comfy-Org/ComfyUI#16457); it ships only because these bundled nodes import it.
++ lib.optionals (ps ? torchaudio && available ps.torchaudio) [ ps.torchaudio ]
++ [ ps."color-matcher" ] # Color matching (hyphenated name needs quoting)
# Common custom-node deps ("it just works" set)
++ lib.optionals (ps ? ollama && available ps.ollama) [ ps.ollama ]
Expand All @@ -269,7 +272,6 @@ let
optionals =
torchPackages
++ lib.optionals (ps ? torchvision && available ps.torchvision) [ ps.torchvision ]
++ lib.optionals (ps ? torchaudio && available ps.torchaudio) [ ps.torchaudio ]
++ lib.optionals (ps ? torchsde && available ps.torchsde) [ ps.torchsde ]
# kornia-rs is still marked bad on aarch64-linux in pinned nixpkgs.
++ lib.optionals (
Expand Down
Loading