Skip to content

fix(deps): update rustls-webpki and bundled root certificates - #438

Merged
smith-and-web merged 1 commit into
mainfrom
claude/clever-goldwasser-31c12d
Nov 6, 2026
Merged

smith-and-web merged 1 commit into
mainfrom
claude/clever-goldwasser-31c12d

Conversation

@smith-and-web

Copy link
Copy Markdown
Owner

Clears the Cargo Security Audit job, which has been red on main since 2026-10-26 and on every PR since.

What fails, and what this does

Only 5 advisories (6 lockfile entries) fail cargo audit. The other 12 are unmaintained warnings, already non-failing via informational_warnings in src-tauri/.cargo/audit.toml.

Advisory Crate Pulled in by Action
RUSTSEC-2026-0382 rustls-webpki 0.103.15 → 0.103.16 reqwest 0.12 (feedback POST), reqwest 0.13 (updater) cargo update
RUSTSEC-2026-0381 webpki-roots 1.0.8 → 1.0.11 hyper-rustls / reqwest 0.12 cargo update
RUSTSEC-2026-0383 webpki-root-certs 1.0.6 → 1.0.11 rustls-platform-verifier ← reqwest 0.13 cargo update
RUSTSEC-2026-0385 ctutils 0.4.3 → 0.4.8 digest ← zip 9 (kindling) cargo update
RUSTSEC-2026-0429 zip 0.6.6, 4.6.1 docx-rs 0.4, tauri-plugin-updater 2.10 accepted in audit.toml

The four updates are patch-level: cargo update -p rustls-webpki -p webpki-roots -p webpki-root-certs -p ctutils moves exactly those four lines, with no manifest change. The first three affect certificate validation on the app's two network calls (updater, feedback).

Why RUSTSEC-2026-0429 is accepted. The bug is ZipArchive::extract aborting on a crafted symlink entry. Kindling's own zip is 9.x, which is patched, and none of its ZipArchive uses call extract. The two older copies are not reachable:

  • docx-rs uses zip 0.6.6 only to write DOCX. Kindling never calls read_docx. The latest docx-rs (0.4.22) is still on zip 8.
  • tauri-plugin-updater's extract_zip serves only legacy v1 .zip bundles. tauri.conf.json sets createUpdaterArtifacts: true, not v1Compatible, and extraction would run only after minisign verification anyway.

The entry sits in the existing zip < 9 block, with the same removal condition.

Not in this PR

Verification

  • cargo audit: exit 0 (12 allowed warnings)
  • cargo test --all-features: 653 passed
  • cargo clippy --all-targets --all-features -- -D warnings: clean

🤖 Generated with Claude Code

Patch-level lockfile updates that clear the cargo audit failures on main:

- rustls-webpki 0.103.15 -> 0.103.16 (RUSTSEC-2026-0382)
- webpki-roots 1.0.8 -> 1.0.11 (RUSTSEC-2026-0381)
- webpki-root-certs 1.0.6 -> 1.0.11 (RUSTSEC-2026-0383)
- ctutils 0.4.3 -> 0.4.8 (RUSTSEC-2026-0385)

The first three affect TLS on the updater and feedback requests.

Also accept RUSTSEC-2026-0429 (zip < 9 extract abort on symlink entries) in
.cargo/audit.toml. Kindling's own zip 9.x is patched; the two older copies
come from docx-rs (write-only here) and tauri-plugin-updater (extract only
for legacy v1 .zip bundles, which kindling does not produce, and only after
minisign verification).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@smith-and-web
smith-and-web merged commit 46bd86c into main Nov 6, 2026
16 checks passed
@smith-and-web
smith-and-web deleted the claude/clever-goldwasser-31c12d branch November 6, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant