Repository navigation
chore(deps): replace deprecated serde_yaml with serde_norway - #439
Merged
Merged
Conversation
serde_yaml 0.9.34 is deprecated and pulls in unsafe-libyaml, which is unmaintained (RUSTSEC-2024-0449). serde_norway is a maintained fork with the same API and an identical parser and emitter, built on unsafe-libyaml-norway, which has no advisories. serde_yml was ruled out as unsound (RUSTSEC-2025-0068), and serde_yaml_ng still depends on unsafe-libyaml. Frontmatter round-trip is unchanged: emitted, re-emitted and error output were compared byte-for-byte against serde_yaml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serde_yaml0.9.34, which is deprecated and depends on the unmaintainedunsafe-libyaml(RUSTSEC-2024-0449), withserde_norway0.9.42.serde_norwayis a maintained fork built onunsafe-libyaml-norway, which has no advisories.serde_yaml::toserde_norway::at 25 call sites inparsers/longform.rs,parsers/markdown.rsandcommands/export.rs. No logic changes.Crate choice
serde_ymlserde_yaml_ngunsafe-libyaml, so 0449 would remainserde_norwayserde_yamlapart from let-else refactorsRound-trip compatibility
A scratch binary compared
serde_yaml0.9.34 withserde_norway0.9.42 on scene-style frontmatter (wikilinks, quotes, colons, multiline, unicode,#/-prefixes, numeric strings, flattened maps). Three outputs were checked:All three were byte-identical.
Test plan
cargo test --all-features: 653 passedcargo clippy --all-targets --all-features -- -D warnings: cleancargo fmt --all -- --check: cleancargo auditno longer lists RUSTSEC-2024-0449 (11 allowed warnings, down from 12)Note: on this branch,
cargo auditstill reports the 6 vulnerabilities that #438 fixes. The Security Audit check will fail here until #438 is merged into main.🤖 Generated with Claude Code