Skip to content

fix(cli): remove obsolete xattrs metadata backend support #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asaah262 wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −2
Draft

fix(cli): remove obsolete xattrs metadata backend support #3840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions opencloud/pkg/command/decomposedfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,6 @@ func setCmd(_ *config.Config) *cobra.Command {

func backend(backend string) metadata.Backend {
switch backend {
case "xattrs":
return metadata.NewXattrsBackend(cache.Config{})
case "mpk":
return metadata.NewMessagePackBackend(cache.Config{})
}
Expand Down
33 changes: 33 additions & 0 deletions opencloud/pkg/command/decomposedfs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package command

import (
"testing"

"github.com/opencloud-eu/reva/v2/pkg/storage/pkg/decomposedfs/metadata"
"github.com/test-go/testify/require"
)

func TestBackend(t *testing.T) {
tests := []struct {
name string
bod string
want metadata.Backend
}{
{
name: "selects messagepack",
bod: "mpk",
want: metadata.MessagePackBackend{},
},
{
name: "xattrs is no longer supported",
bod: "xattrs",
want: metadata.NullBackend{},
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
require.IsType(t, tt.want, backend(tt.bod))
})
}
}