Skip to content

fix(cli): remove obsolete xattrs metadata backend support - #3840

Draft
asaah262 wants to merge 1 commit into
opencloud-eu:mainfrom
asaah262:fix/3048-deprecate-and-remove-xattrs-metadata
Draft

asaah262 wants to merge 1 commit into
opencloud-eu:mainfrom
asaah262:fix/3048-deprecate-and-remove-xattrs-metadata

Conversation

@asaah262

@asaah262 asaah262 commented Oct 27, 2026 •

Copy link
Copy Markdown

Note

Requires merging opencloud-eu/reva#923 before merging this PR

Description

Remove the obsolete xattrs metadata backend selection from OpenCloud's decomposedfs CLI.

  • Remove the reference to metadata.NewXattrsBackend(), which is being removed from Reva.
  • Keep the existing MessagePack backend selection unchanged.
  • Preserve the existing NullBackend fallback for unsupported metadata backends.
  • Add unit tests covering MessagePack and xattrs backend selection.

Related Issue

Motivation and Context

The modern XattrsBackend implementation is being removed from Reva as part of issue #3048.

OpenCloud's decomposedfs CLI still references NewXattrsBackend(), which causes a compilation error when building OpenCloud against the updated Reva.

Since OpenCloud does not expose the obsolete xattrs metadata backend as a configurable option, this change removes the unused reference while preserving the existing MessagePack functionality.

How Has This Been Tested?

  • Test environment: macOS, using OpenCloud with both its vendored Reva dependency and a modified local Reva worktree through go.work.
  • Test case 1: Verify that backend("mpk") returns MessagePackBackend.
  • Test case 2: Verify that backend("xattrs") returns NullBackend.

Validation commands:

GOWORK=off go test -mod=vendor ./opencloud/pkg/command -run '^TestBackend$' -count=1 -v
go test ./opencloud/pkg/command -count=1
go build ./...

All checks passed.

Screenshots (if appropriate)

Not applicable.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@maki5 maki5 removed the status in OpenCloud Team Board Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants