Skip to content

fix: clear prop for getter calls with a message in assert delta helpers #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
43081j merged 2 commits into from
Oct 27, 2026
Merged

fix: clear prop for getter calls with a message in assert delta helpers #1886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfc76f2
fix: clear prop for getter calls with a message in assert delta helpers
Enesuygurs Oct 23, 2026
9a688f2
Merge branch 'main' into fix/assert-delta-getter-message
43081j Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/chai/interface/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1978,7 +1978,7 @@
* @name throws
* @alias throw
* @alias Throw
* @param {Function} fn

Check warning on line 1981 in lib/chai/interface/assert.js

View workflow job for this annotation

GitHub Actions / lint 

Prefer a more specific type to `Function`
* @param {Error} errorLike
* @param {RegExp | string} errMsgMatcher
* @param {string} msg
Expand Down Expand Up @@ -2020,7 +2020,7 @@
* assert.doesNotThrow(fn, errorInstance, /Error must not match this/);
*
* @name doesNotThrow
* @param {Function} fn

Check warning on line 2023 in lib/chai/interface/assert.js

View workflow job for this annotation

GitHub Actions / lint 

Prefer a more specific type to `Function`
* @param {Error} errorLike
* @param {RegExp | string} errMsgMatcher
* @param {string} message
Expand Down Expand Up @@ -2532,7 +2532,7 @@
* assert.oneOf(1, [ 2, 1 ], 'Not found in list');
*
* @name oneOf
* @param {*} inList

Check warning on line 2535 in lib/chai/interface/assert.js

View workflow job for this annotation

GitHub Actions / lint 

Prefer a more specific type to `*`
* @param {Array<*>} list
* @param {string} msg
* @namespace Assert
Expand Down Expand Up @@ -2614,6 +2614,7 @@
let tmpMsg = delta;
delta = prop;
msg = tmpMsg;
prop = null;
} else if (arguments.length === 3) {
delta = prop;
prop = null;
Expand Down Expand Up @@ -2675,6 +2676,7 @@
let tmpMsg = delta;
delta = prop;
msg = tmpMsg;
prop = null;
} else if (arguments.length === 3) {
delta = prop;
prop = null;
Expand Down Expand Up @@ -2735,6 +2737,7 @@
let tmpMsg = delta;
delta = prop;
msg = tmpMsg;
prop = null;
} else if (arguments.length === 3) {
delta = prop;
prop = null;
Expand Down Expand Up @@ -2798,6 +2801,7 @@
let tmpMsg = delta;
delta = prop;
msg = tmpMsg;
prop = null;
} else if (arguments.length === 3) {
delta = prop;
prop = null;
Expand Down Expand Up @@ -2858,6 +2862,7 @@
let tmpMsg = delta;
delta = prop;
msg = tmpMsg;
prop = null;
} else if (arguments.length === 3) {
delta = prop;
prop = null;
Expand Down Expand Up @@ -2923,6 +2928,7 @@
let tmpMsg = delta;
delta = prop;
msg = tmpMsg;
prop = null;
} else if (arguments.length === 3) {
delta = prop;
prop = null;
Expand Down Expand Up @@ -2956,6 +2962,7 @@
let tmpMsg = delta;
delta = prop;
msg = tmpMsg;
prop = null;
} else if (arguments.length === 3) {
delta = prop;
prop = null;
Expand Down
10 changes: 10 additions & 0 deletions test/assert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2460,6 +2460,8 @@ describe('assert', function () {
assert.doesNotChange(smFn, getterFn, 'value');
assert.changesButNotBy(fnDec, obj, 'value', 1);
assert.changesButNotBy(fnDec, getterFn, 1);
assert.changesBy(fn, getterFn, 5, 'via getter function');
assert.changesButNotBy(fnDec, getterFn, 1, 'via getter function');

assert.changes(bangFn, obj, 'str');

Expand Down Expand Up @@ -2496,6 +2498,10 @@ describe('assert', function () {
err(function () {
assert.changesButNotBy(fn, obj, 'value', 5, 'blah');
}, "blah: expected .value to not change by 5");

err(function () {
assert.changesBy(smFn, function () { return 1 }, 1, 'blah');
}, "blah: expected 1 to change");
});

it('increase, decrease', function() {
Expand All @@ -2517,6 +2523,8 @@ describe('assert', function () {
assert.decreasesBy(decFn, getterFn, 3);
assert.decreasesButNotBy(decFn, obj, 'value', 10);
assert.decreasesButNotBy(decFn, getterFn, 10);
assert.decreasesBy(decFn, getterFn, 3, 'via getter function');
assert.decreasesButNotBy(decFn, getterFn, 10, 'via getter function');

assert.increases(incFn, obj, 'value');
assert.increases(incFn, getterFn, 'increases via getter function');
Expand All @@ -2526,6 +2534,8 @@ describe('assert', function () {
assert.increasesBy(incFn, getterFn, 2);
assert.increasesButNotBy(incFn, obj, 'value', 1);
assert.increasesButNotBy(incFn, getterFn, 1);
assert.increasesBy(incFn, getterFn, 2, 'via getter function');
assert.increasesButNotBy(incFn, getterFn, 1, 'via getter function');

const zeroArr = [10];
const zeroInc = function() { zeroArr[0] += 2 };
Expand Down
Loading