Repository navigation
fix: clear prop for getter calls with a message in assert delta helpers - #1886
Merged
Merged
Conversation
43081j
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
*Byassert helpers documentobjas "object or getter function", with an optionalpropertyand an optionalmessage. That coverschangesBy,changesButNotBy,increasesBy,increasesButNotBy,decreasesBy,decreasesButNotByanddoesNotDecreaseBy. Passing a getter together with a message doesn't work, though:The 4-argument branch (
arguments.length === 4 && typeof obj === 'function') moves the delta and the message into place, but it leavespropset to the delta..increase(obj, prop)then looks for a property named2on the getter. The 3-argument branch right below it already resetsproptonull, as doassert.changes/increases/decreases. This change does the same in the 4-argument branch of all seven helpers.I added getter + message cases to the existing
changeandincrease, decreasetests intest/assert.js. They fail onmainwith the error above and pass with this change.npm run test-nodepasses (512 tests), and eslint reports no errors.