Skip to content

Record build mode only after successful install #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Record build mode only after successful install #3248

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c83fa6a
Record build mode only after successful install
dajiaohuang Oct 2, 2026
831349b
fix: invalidate previous mode before full extension builds
dajiaohuang Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion scripts/build_pg_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ def run(mode: str, incremental: bool, deeplake_link_type: str = None, pg_version
if mode not in modes:
raise Exception(f"Invalid mode - '{mode}'. Possible values - {', '.join(modes)}")

if not incremental:
invalidate_mode()

os.chdir("cpp")

# include path to specific verison from manylinux docker container in the path, so vcpkg_find_acquire_package can find it
Expand Down Expand Up @@ -178,7 +181,8 @@ def run(mode: str, incremental: bool, deeplake_link_type: str = None, pg_version

finally:
os.chdir("..")
write_mode(mode)

write_mode(mode)
Comment thread
coderabbitai[bot] marked this conversation as resolved.

def read_mode():
try:
Expand All @@ -194,6 +198,20 @@ def read_mode():
raise Exception("No previous mode found for incremental build. Please run full build.")


def invalidate_mode():
try:
with open('.buildinfo') as f:
data = json.load(f)
except (FileNotFoundError, json.JSONDecodeError):
return

previous = data.get("deeplake-pg")
if isinstance(previous, dict) and "mode" in previous:
del previous["mode"]
with open('.buildinfo', 'w') as f:
json.dump(data, f)


def write_mode(mode: str):
data = dict()
try:
Expand Down