Skip to content

Return failure for incomplete parallel TPC-H loads #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dajiaohuang wants to merge 2 commits into from
Closed

Return failure for incomplete parallel TPC-H loads #3244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1eed016
Return failure for incomplete parallel TPC-H loads
dajiaohuang Oct 2, 2026
012d35f
fix: fail ingestion when requested table input is missing
dajiaohuang Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/tpch_deeplake_ingest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,7 @@ def main():

# Phase 2: Load data
overall_start = time.time()
failed_tables = []

if args.sequential:
# Sequential: one connection, all tables
Expand All @@ -371,14 +372,20 @@ def main():
try:
results.append(future.result())
except Exception as e:
failed_tables.append(table_name)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
log(f"[{table_name}] FAILED: {e}")

overall_elapsed = time.time() - overall_start
total_rows = sum(r[1] for r in results)

log(f"\nDone. {total_rows:,} total rows in {overall_elapsed:.1f}s (wall time)")
if failed_tables:
log(f"\nFinished with {len(failed_tables)} failed table(s): {', '.join(failed_tables)}")
else:
log(f"\nDone. {total_rows:,} total rows in {overall_elapsed:.1f}s (wall time)")
for table_name, row_count, elapsed in sorted(results, key=lambda x: x[0]):
log(f" {table_name:<12} {row_count:>12,} rows {elapsed:>7.1f}s")
if failed_tables:
sys.exit(1)


if __name__ == '__main__':
Expand Down