Skip to content

Remove the package.json step from the markets recipe #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucyxiang merged 1 commit into from
Nov 4, 2026
Merged

Remove the package.json step from the markets recipe #4300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 0 additions & 45 deletions cookbook/llms/markets.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5077,51 +5077,6 @@ async function predictiveSearch({

~~~

### Step 3: package.json

Use published versions of the Hydrogen, React and tooling packages in `package.json` instead of the monorepo's workspace references.

#### File: /package.json

~~~diff
@@ -14,12 +14,12 @@
},
"prettier": "@shopify/prettier-config",
"dependencies": {
- "@shopify/hydrogen": "workspace:*",
+ "@shopify/hydrogen": "2026.4.0",
"graphql": "^16.10.0",
"graphql-tag": "^2.12.6",
"isbot": "^5.1.22",
- "react": "catalog:",
- "react-dom": "catalog:",
+ "react": "^18.3.1",
+ "react-dom": "^18.3.1",
"react-router": "7.16.0",
"react-router-dom": "7.16.0"
},
@@ -31,14 +31,14 @@
"@react-router/dev": "7.16.0",
"@react-router/fs-routes": "7.16.0",
"@shopify/cli": "3.93.2",
- "@shopify/hydrogen-codegen": "workspace:*",
- "@shopify/mini-oxygen": "workspace:*",
+ "@shopify/hydrogen-codegen": "0.3.3",
+ "@shopify/mini-oxygen": "4.0.2",
"@shopify/oxygen-workers-types": "^4.1.6",
- "@shopify/prettier-config": "catalog:",
+ "@shopify/prettier-config": "^1.1.2",
"@total-typescript/ts-reset": "^0.6.1",
"@types/eslint": "^9.6.1",
- "@types/react": "catalog:",
- "@types/react-dom": "catalog:",
+ "@types/react": "^18.3.28",
+ "@types/react-dom": "^18.3.7",
"@typescript-eslint/eslint-plugin": "^8.21.0",
"@typescript-eslint/parser": "^8.21.0",
"eslint": "^9.18.0",
~~~

## Deleted Files

- [`templates/skeleton/app/routes/_index.tsx`](templates/skeleton/app/routes/_index.tsx)
Expand Down
48 changes: 0 additions & 48 deletions cookbook/recipes/markets/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5176,54 +5176,6 @@ async function predictiveSearch({

</details>

### Step 3: package.json

Use published versions of the Hydrogen, React and tooling packages in `package.json` instead of the monorepo's workspace references.

#### File: [package.json](https://github.com/Shopify/hydrogen/blob/68f62c423b5382cb6a98a4f0000d656bf98b9c13/templates/skeleton/package.json)

~~~diff
index 0bb332639..651bbfffa 100644
--- a/templates/skeleton/package.json
+++ b/templates/skeleton/package.json
@@ -14,12 +14,12 @@
},
"prettier": "@shopify/prettier-config",
"dependencies": {
- "@shopify/hydrogen": "workspace:*",
+ "@shopify/hydrogen": "2026.4.0",
"graphql": "^16.10.0",
"graphql-tag": "^2.12.6",
"isbot": "^5.1.22",
- "react": "catalog:",
- "react-dom": "catalog:",
+ "react": "^18.3.1",
+ "react-dom": "^18.3.1",
"react-router": "7.16.0",
"react-router-dom": "7.16.0"
},
@@ -31,14 +31,14 @@
"@react-router/dev": "7.16.0",
"@react-router/fs-routes": "7.16.0",
"@shopify/cli": "3.93.2",
- "@shopify/hydrogen-codegen": "workspace:*",
- "@shopify/mini-oxygen": "workspace:*",
+ "@shopify/hydrogen-codegen": "0.3.3",
+ "@shopify/mini-oxygen": "4.0.2",
"@shopify/oxygen-workers-types": "^4.1.6",
- "@shopify/prettier-config": "catalog:",
+ "@shopify/prettier-config": "^1.1.2",
"@total-typescript/ts-reset": "^0.6.1",
"@types/eslint": "^9.6.1",
- "@types/react": "catalog:",
- "@types/react-dom": "catalog:",
+ "@types/react": "^18.3.28",
+ "@types/react-dom": "^18.3.7",
"@typescript-eslint/eslint-plugin": "^8.21.0",
"@typescript-eslint/parser": "^8.21.0",
"eslint": "^9.18.0",
~~~

## Deleted Files

- [templates/skeleton/app/routes/account.$.tsx](https://github.com/Shopify/hydrogen/blob/68f62c423b5382cb6a98a4f0000d656bf98b9c13/templates/skeleton/app/routes/account.$.tsx)
Expand Down
39 changes: 0 additions & 39 deletions cookbook/recipes/markets/patches/package.json.8e0ff5.patch
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions cookbook/recipes/markets/recipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,14 +445,6 @@ steps:
predictive search.
ingredients:
- path: templates/skeleton/app/routes/($locale).search.tsx
- type: PATCH
step: "3"
name: package.json
description: Use published versions of the Hydrogen, React and tooling packages
in `package.json` instead of the monorepo's workspace references.
diffs:
- file: package.json
patchFile: package.json.8e0ff5.patch
nextSteps: |
- Test your implementation by going to your store and selecting a different
market from the country selector.
Expand Down
Loading