Skip to content

Remove the package.json step from the markets recipe - #4300

Merged
lucyxiang merged 1 commit into
2026-04from
lucy/markets-drop-package-json-step
Nov 4, 2026
Merged

lucyxiang merged 1 commit into
2026-04from
lucy/markets-drop-package-json-step

Conversation

@lucyxiang

@lucyxiang lucyxiang commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR: The markets recipe has a package.json step that only works inside this monorepo. This PR removes the step.

The patch only replaces workspace: and catalog: references with published
versions. Projects created with npm create @Shopify/hydrogen already use
published versions, so the step does not apply to them. Recipe validation
resolves these references itself before it applies the recipe.
@lucyxiang
lucyxiang requested a review from a team as a code owner November 4, 2026 16:19
@shopify

shopify Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Oxygen deployed a preview of your lucy/markets-drop-package-json-step branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment November 4, 2026 4:21 PM

Learn more about Hydrogen's GitHub integration.

@lucyxiang
lucyxiang added this pull request to the merge queue Nov 4, 2026
Merged via the queue into 2026-04 with commit 085d418 Nov 4, 2026
21 checks passed
@lucyxiang
lucyxiang deleted the lucy/markets-drop-package-json-step branch November 4, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants