Repository navigation
gh-16314: Hide Set Profile option in private windows - #16319
Merged
Merged
Conversation
Signed-off-by: hrushikeshramilla <ramillahrushikesh@gmail.com>
mr-cheffy
requested changes
Nov 1, 2026
| menu.hidden = !gZenWorkspaces.shouldShowContainers; | ||
| const show = gZenWorkspaces.shouldShowContainers; | ||
| menu.hidden = !show; | ||
| if (separator) { |
| contextMenu.addEventListener("popupshowing", event => { | ||
| if (event.target === contextMenu) { | ||
| menu.hidden = !gZenWorkspaces.shouldShowContainers; | ||
| const show = gZenWorkspaces.shouldShowContainers; |
Member
There was a problem hiding this comment.
Suggested change
| const show = gZenWorkspaces.shouldShowContainers; | |
| const hidden = !gZenWorkspaces.shouldShowContainers; |
Contributor
Author
There was a problem hiding this comment.
Updated as suggested, thanks!
Signed-off-by: hrushikeshramilla <ramillahrushikesh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16314
Problem
Firefox contextual identity containers are not supported in private browsing windows. However, when right-clicking the workspace indicator ("Incognito") in the sidebar or opening the tab context menu in a private window, the "Set Profile" submenu was still visible because
shouldShowContainersonly checkedprivacy.userContext.ui.enabledand public identity count, omitting a check for private browsing windows.Fix
shouldShowContainersinZenSpaceManager.mjsto returnfalsein private browsing windows (!this.isPrivateWindow).ZenVerticalTabsManager.mjsis hidden alongsidezen-toolbar-context-set-profilewhen containers are hidden.browser_private_mode.jsconfirmingshouldShowContainersisfalseandcontext_zenWorkspacesOpenInContainerTabis hidden in private windows.