Repository navigation
Conversation
mr-cheffy
requested changes
Nov 1, 2026
mr-cheffy
left a comment
mr-cheffy
left a comment
Member
There was a problem hiding this comment.
Please make an issue and link it to this PR, like the other pull requests. Thanks!
Also, no need for the tests
luantak
changed the title
luantak
force-pushed
the
fix/right-sidebar-toggle-tested
branch
from
November 1, 2026 22:32
be2dfa2 to
ee119aa
Compare
Author
|
@mr-cheffy linked #16321, removed the added tests. Could you take another look? Thanks! |
luantak
force-pushed
the
fix/right-sidebar-toggle-tested
branch
from
November 1, 2026 22:37
ee119aa to
83837c9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16321.
The left sidebar already keeps the compact-mode toggle near the outside edge when the sidebar opens or closes. With the expanded right sidebar in the multiple-toolbar layout, the button instead jumps horizontally between the sidebar header and navigation toolbar.
End-align the sidebar's top button group and place that group after the application menu when it moves into the compact navigation toolbar. Both rules are limited to the expanded right sidebar with multiple toolbars.
Issue #16321 compares the existing left and right behavior with actual Zen screenshots and reproduction steps.
Validation
npm run build -- --jobs 12(about 21 minutes). The CSS fix is unchanged from that tested build.npm run build:ui.npm test -- compact_mode --headless— 16 checks across 3 tests passed, zero unexpected results.git diff --checkpassed.Full build log · Left/right comparison captures and measurements
Actual Zen before/after screenshots
Unedited full-window captures of the locally built Zen executable, running on Xvfb with isolated profiles and a 1280×800 window. The development build uses the default unofficial “Nightly” branding. The compact-mode toggle is the split-panel icon near the top-right.
Follow-up to #16280 with a real source build and actual Zen screenshots.