Repository navigation
Conversation
… after #1452 + #1487) #1452 made parse_args_from return Result<CliArgs, String> (a missing flag value is refused); #1487's auto_port_is_off_unless_asked_for, written against the old signature, passes the Result straight to load_config. Each PR was green alone; the merged tree fails to compile the xerj-server bin tests (E0308 at main.rs:3682/3685), so Format + Clippy and Build + Test are red for main and every PR. Unwrap, as every other parse_args_from caller in the test module does. cargo test --release -p xerj-server --bin xerj: all pass; fmt clean.
xerj-org
changed the title
xerj-org
added a commit
that referenced
this pull request
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red in two places, both merge skews. Each one breaks CI on every PR (first seen on the rc.96 release PR #1493):
xerjandxerj index#1452 changedparse_args_fromto returnResult<CliArgs, String>. feat(server): support multi-instance execution with dynamic port and data-dir allocation #1487'sauto_port_is_off_unless_asked_forpasses thatResultstraight toload_config(E0308 atmain.rs:3682/3685). Fixed with two.unwrap()calls, as every other caller in the module does."Jarvis636431"with no comma before"leninworld", so.contributorsis invalid JSON (jq: Expected separator … line 25). Comma restored. No entry is added or removed, and it parses (28 entries).cargo test --release -p xerj-server --bin xerj: 86 passedcargo fmt --all --check: clean🤖 Generated with Claude Code