Repository navigation
Conversation
… test) main (ea1263a) fails two required checks on every PR. Neither comes from the PR that hit them first (#1505): 1. CLA gate config: `.contributors` is not valid JSON. The merge of chore/prepare-cla-jarvis636431 (b7dc713) left `"Jarvis636431"` without a trailing comma, so `jq` fails with "Expected separator between values at line 25, column 14". Fix: add the comma back. 2. Format + Clippy (and every job that compiles xerj-server tests): #1452 made `parse_args_from` return `Result<CliArgs, String>`, and #1487 (b0b41b9.. ec6ef06) added `auto_port_tests::auto_port_is_off_unless_asked_for`, which passes its result straight to `load_config(&CliArgs)`. Each PR was green alone; together they give E0308 at main.rs:3682/3685. Fix: `.unwrap()` the parse, as the other parse_args_from tests already do. Checks: jq passes both CLA-gate assertions, and cargo fmt --check passes on xerj-server. `cargo test -p xerj-server --bin xerj auto_port` runs locally.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main (ea1263a) fails two required checks on every PR. Neither comes from
the PR that hit them first (#1505):
CLA gate config:
.contributorsis not valid JSON. The merge ofchore/prepare-cla-jarvis636431 (b7dc713) left
"Jarvis636431"without a trailing comma, so
jqfails with "Expected separator betweenvalues at line 25, column 14". Fix: add the comma back.
Format + Clippy (and every job that compiles xerj-server tests): fix(cli): refuse a missing or non-numeric flag value in
xerjandxerj index#1452 madeparse_args_fromreturnResult<CliArgs, String>, and feat(server): support multi-instance execution with dynamic port and data-dir allocation #1487 (b0b41b9..ec6ef06) added
auto_port_tests::auto_port_is_off_unless_asked_for, whichpasses its result straight to
load_config(&CliArgs). Each PR was greenalone; together they give E0308 at main.rs:3682/3685. Fix:
.unwrap()theparse, as the other parse_args_from tests already do.
Checks: jq passes both CLA-gate assertions, and cargo fmt --check passes on
xerj-server.
cargo test -p xerj-server --bin xerj auto_portruns locally.🤖 Generated with Claude Code