Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the Zephyr entropy-driver changes and accompanying documentation updates.
No open issues 🎉
What changed in this PR
This PR routes STM32 seeding through Zephyr’s entropy driver when available, preventing wolfSSL’s direct RNG implementation from competing for the same peripheral.
Changes:
- Suppresses automatic
STM32_RNGenablement when Zephyr has an entropy driver. - Updates comments describing Zephyr seed-source requirements and FIPS v5 handling.
- Corrects the Realtek entropy-driver documentation and recommends using it instead of
WC_HUK_DEVIDon Zephyr.
| File | Description |
|---|---|
zephyr/user_settings.h |
Clarifies Zephyr entropy requirements and the FIPS v5 seed callback. |
wolfssl/wolfcrypt/settings.h |
Leaves automatic STM32 RNG enablement off when Zephyr provides entropy. |
wolfcrypt/src/port/realtek/README.md |
Corrects the documented driver name and Zephyr seed-source guidance. |
Review effort: Balanced
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Zephyr, a
WOLFSSL_STM32xxdefine turned onSTM32_RNG, so wolfSSL and Zephyr'sentropy_stm32driver both drove the RNG.settings.hnow leavesSTM32_RNGoff when Zephyr has an entropy driver, so the seed comes fromzephyr,entropy. Tested on a NUCLEO-H563ZI under Zephyr 4.4: the shared-RNG builds stalled Zephyr's entropy or failedwc_InitRng()before the change and pass after it.