Repository navigation
Conversation
|
|
Fix confirmed by customer |
|
retest this please |
|
@claude review |
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved DNS and mailbox validation gaps allow supported single-label hostnames and malformed email names to bypass name constraints, including a critical CN-fallback path that can authenticate localhost outside a CA’s permitted scope.
2 open issues
Review effort: Balanced
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11948
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): certs/test/cert-ext-nc-empty-dns.der, certs/test/cert-ext-nc-empty-dns.pem, certs/test/gen-ext-certs.sh, certs/test/include.am, tests/api/test_certman.h
Coverage: 6 of 7 in-scope changed file(s) opened by the reviewer; not opened: tests/api/test_asn.c
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Max
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11948
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs, wolfssl-src, wolfssl-bugs
Not reviewed (no scan target covers them): certs/test/cert-ext-nc-empty-dns.der, certs/test/cert-ext-nc-empty-dns.pem, certs/test/gen-ext-certs.sh, certs/test/include.am, tests/api/test_certman.h
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.


Description
Two inputs let a certificate escape an excluded name constraint subtree:
excluded: DNS:(zero-length), the CA/Browser Forum encoding for a sub-CA that may not issue DNS names, was treated as matching nothing. Per RFC 5280 4.2.1.10 it now matches every DNS name, in the native and OpenSSL compat paths. A lone"."base is treated the same way unlessOPENSSL_COMPATIBLE_DEFAULTSisdefined.
"x@y"@evil.comescapedexcluded: email:evil.combecause two '@' characters made the name "invalid". The mailbox is now split at its last '@'. An '@' outside a quoted local-part makes the name uncomparable, and the certificate is rejected on both permitted and excluded subtrees.The subject CN fallback for DNS constraints now applies only to CNs with host name syntax, so an empty excluded dNSName does not reject S/MIME or client-auth leaves whose CN is a person's name.
Fixes zd22724
Testing
tests/api/test_asn.c,tests/api/test_ossl_x509_ext.candtests/unit-mcdc/test_asn_ext_whitebox.c.asnandossl_x509_extgroups and the white-box smoke run pass with--enable-alland with--disable-openssl-compatible-defaults.Checklist