Repository navigation
TLS ECH: cleanup tests and state management - #11626
sebastian-carpenter wants to merge 2 commits into
Conversation
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The refactor removes the only HRR coverage for clearing retry configurations after authentication failure.
Review effort: Balanced
Findings: 1
What changed in this PR
Cleans up TLS ECH state handling, diagnostics, interoperability, and tests.
Changes:
- Routes ECH configuration and response state through the ECH extension.
- Expands and simplifies ECH/SNI tests.
- Adds ECH status logging and runtime-generated rejection configs.
| File | Description |
|---|---|
wolfssl/test.h |
Adds ECH status output helper. |
tests/api.c |
Refactors and expands ECH tests. |
src/tls13.c |
Simplifies ECH state access during TLS 1.3 handshakes. |
src/tls.c |
Moves ECH response setup and config access into parsing. |
examples/server/server.c |
Logs server ECH status. |
examples/client/client.c |
Logs client ECH status. |
.github/scripts/openssl-ech.sh |
Generates rejection configs dynamically and improves synchronization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
8d88ae7 to
6594f04
Compare
|
jenkins retest this please |
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11626
Scan targets checked: wolfssl-src, wolfssl-bugs
Coverage: 3 of 4 in-scope changed file(s) opened by the reviewer; not opened: wolfssl/test.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
|
Looks good. Assigning back though for merge conflicts. |
6594f04 to
2497837
Compare
|
Made a few touchups to the TLSv1.2 tests added for ECH and some associated code. I also hardened the interop test a bit more. Changes not related to the rebase were broken out into a new commit. |

Description
Breaking some changes out of #10913.
Code:
Testing:
Examples:
Openssl Interop:
Test
This should test the majority:
./configure --enable-all --enable-ech --enable-dtls --enable-dtls13 --enable-readahead --enable-keylog-export CFLAGS="-DWOLFSSL_TEST_ECH"This tests a particular SNI case that used to be an issue:
./configure --enable-all --enable-ech --enable-dtls --enable-dtls13 --enable-readahead --enable-keylog-export CFLAGS="-DWOLFSSL_TEST_ECH -DWOLFSSL_ALWAYS_KEEP_SNI"Checklist