Repository navigation
Keep out CAs from cert manager if allowed only by callback #11110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattia-moffa
wants to merge
20
commits into
wolfSSL:master
Choose a base branch
from
mattia-moffa:20260806-ca-trust-sslctx
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+734
−156
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a10f61a
Confine callback-accepted chain CAs to their own connection
mattia-moffa f017778
Remove code repetition
mattia-moffa 0cbac24
Fix test #define gating
mattia-moffa 85a8592
Address Fenrir findings
mattia-moffa 25fa25f
Fix handling of CAs waived by the verify callback
mattia-moffa 93ac3a2
Fix server only build
mattia-moffa 9888cf9
ParseCertRelative NO_SKID: don't rerun GetCA if CA already found
mattia-moffa 54a28ec
Let OCSP find CAs the verify callback accepted
mattia-moffa 89307a1
Ensure wolfSSL_clear() also clears the waived CA list
mattia-moffa 6bf68e7
Let stapled OCSP responses find CAs accepted by verify callback
mattia-moffa 9afe5a1
Don't cache chain CA whose CRL result was held for OCSP staple
mattia-moffa 11dc317
Let CRL checks and X509_verify_cert find CAs waived by verify callback
mattia-moffa d58d991
Don't cache OCSP responses signed by a CA waived by cert callback
mattia-moffa e930d7c
Reset the waived CA list for each Certificate message
mattia-moffa 4e49be4
Search the cert manager before the waived CA list
mattia-moffa 6e052c2
Set the word32 unknown extension callback on the chain signer parse
mattia-moffa bfd5e47
Make the chain CA tests prove the connection's CA list is used
mattia-moffa b70240c
Resolve a chain signer's issuer in both pools
mattia-moffa e3e0145
Don't copy a CA into waived CA list if already in cert manager
mattia-moffa 63bb22e
Fix CI failures on new chain CA test
mattia-moffa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing in the suite covers a CRL issued by a waived CA. A memio case CRL-checking
server-chain.pemagainstcerts/crl/ca-int.pemandca-int2.pemwould lock this in.