Repository navigation
Fix duplicate PDF anchor destinations by scoping them to page URLs - #17
Merged
Merged
Conversation
Signed-off-by: Chetan Shekhar <cshekhar@ddn.com>
jparris
reviewed
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The PDF exporter treated identical anchor names from different pages as one global destination. When multiple pages contained the same section anchor, links could navigate to the wrong section after the individual PDFs were merged.
For example, a link to #overview on one page could incorrectly open the Overview section from another page.
Changes:
Scope PDF destinations by their source page URL and anchor.
Normalize page URLs before resolving destinations.
Rewrite internal links using the full page URL and anchor.
Resolve direct PDF destination annotations using their source page.
Add regression coverage for duplicate anchors across multiple pages.