Repository navigation
Fix SSL test certificates, Clang linking and session validity & Fix parallel timeout tests and CI example execution - #155
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Clang runtime compatibility and toolchain library discovery issues remain unresolved.
2 open findings
What changed in this PR
This PR improves C++ client test reliability and CI execution while correcting session validity and Clang linking.
Changes:
- Isolates timeout-test cleanup and accepts all session IDs except
-1. - Updates Clang library linking and example startup handling.
- Generates fresh SSL test certificates and adjusts CI dependencies.
| File | Description |
|---|---|
| src/client/tests/SessionTest.cpp | Restricts cleanup to session-test queries. |
| src/client/tests/ConnectionTest.cpp | Restricts cleanup to connection-test queries. |
| include/nebula/client/Session.h | Uses -1 as the invalid session sentinel. |
| examples/SessionPoolExample.cpp | Waits for space availability before pool initialization. |
| cmake/nebula/SanitizerConfig.cmake | Adds shared ASan runtime linking for Clang. |
| cmake/nebula/GeneralCompilerConfig.cmake | Requires shared libatomic for Clang. |
| .github/workflows/pull_request.yml | Refreshes certificates and adjusts example execution. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xiajingchun
approved these changes
Oct 15, 2026
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
local test access
