Repository navigation
feat: make the first Offing run useful without configuration - #319
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #119
Closes #169
Closes #191
Closes #192
Closes #217
Closes #193
Closes #194
Closes #195
Closes #218
Closes #236
Closes #253
What changed
--jsonuses the existing forecast document unchanged.Quality bar
Reviewed against Reference quality and the review rubric.
Checks CI cannot make
changes/for user-visible changesVerification
npm run checknode --test dist/tests/first-run*.test.js dist/tests/forecast-snapshots.test.jsnode dist/benchmarks/first-run.js: all 67 examples finished under the 5-second budget on macOS arm64 with Node.js 22; the slowest took 1.81 seconds.node dist/benchmarks/first-run.js --npx-size: 5,208,351 compressed bytes across 12 tarballs for the published@velella/offing@0.1.1on macOS arm64.node dist/benchmarks/first-run.js --check: existing smoke fixture reported four findings.npm run example --silent -- demo --as-of 2026-10-25: matched the Quickstart output.Notes for reviewers
The example timings already meet the budget with a real scan and the scan cache disabled, so no detector or scan-engine optimization was necessary. The download measurement is for the published package, not an unreleased tarball from this PR.