Skip to content

fix: replace development tooling paths that require picomatch - #318

Closed
arminazimi wants to merge 4 commits into
mainfrom
fix/317-replace-knip
Closed

arminazimi wants to merge 4 commits into
mainfrom
fix/317-replace-knip

Conversation

@arminazimi

@arminazimi arminazimi commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Closes #317

What changed

  • Normalize Windows paths in project discovery and TypeScript diagnostics. Close the browser test server’s active connections during cleanup and bound the browser test to 60 seconds.

The all-dependency security gate rejects picomatch 4.0.7 for GHSA-fc5q-39xc-vjpf. Both Knip and typescript-eslint's project-file globbing bring it into the development dependency tree.

  • Replace Knip with a check using the installed TypeScript compiler. It follows entry points declared in dead-code.json and package.json, checks reachability and exported symbols, and reports unused or undeclared dependencies.
  • Supply the two project-file glob functions used by the pinned typescript-eslint parser through a local tinyglobby compatibility package backed by glob 14.0.6. Pin the parser and verify its real type-aware project discovery.
  • Update the compatible minimatch patch release to 11.0.9 in the lockfile. Clean installation contains zero copies of picomatch.
  • Document the new entry-point configuration and the local parser adapter.

Quality bar

The dead-code gate runs before the build on a clean checkout. The tests inject unused exports, disconnected files and cycles, unused dependencies, and undeclared packages. They also cover public aliases, local uses, dynamic imports, namespace use, and package binary entry points.

Checks CI cannot make

  • Tests added or updated for changed behavior
  • Changelog fragment added in changes/ for user-visible changes

Development tooling only.

Verification

  • The real forecast browser privacy test passed locally with the cleanup fix. Windows path regressions are exercised in the CI matrix.

  • npm ci

  • npm run check

  • npm audit --json and the repository's check-quality audit gate

  • npm ls tinyglobby glob picomatch confirms the parser shares the local adapter and picomatch is absent.

  • Offing lifecycle checks for glob 14.0.6 and minimatch 11.0.9 returned no-data.

Notes for reviewers

The checker uses static and literal dynamic imports with explicit roots for dynamically discovered modules. Configuration-loaded packages have explicit dependencyReferences. It implements this repository's file, export, and dependency checks. Knip's framework-specific plugin discovery is replaced by this explicit configuration.

The local compatibility package implements the project-file interface of typescript-eslint 8.72.1. Review that consumer and its integration test when upgrading the parser.

Advisory

@arminazimi arminazimi closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI blocked by picomatch high advisory GHSA-fc5q-39xc-vjpf through knip

1 participant