Repository navigation
fix: replace development tooling paths that require picomatch - #318
Closed
arminazimi wants to merge 4 commits into
Closed
arminazimi wants to merge 4 commits into
arminazimi wants to merge 4 commits into
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #317
What changed
The all-dependency security gate rejects picomatch 4.0.7 for GHSA-fc5q-39xc-vjpf. Both Knip and typescript-eslint's project-file globbing bring it into the development dependency tree.
Quality bar
The dead-code gate runs before the build on a clean checkout. The tests inject unused exports, disconnected files and cycles, unused dependencies, and undeclared packages. They also cover public aliases, local uses, dynamic imports, namespace use, and package binary entry points.
Checks CI cannot make
Development tooling only.
Verification
The real forecast browser privacy test passed locally with the cleanup fix. Windows path regressions are exercised in the CI matrix.
npm ci
npm run check
npm audit --json and the repository's check-quality audit gate
npm ls tinyglobby glob picomatch confirms the parser shares the local adapter and picomatch is absent.
Offing lifecycle checks for glob 14.0.6 and minimatch 11.0.9 returned no-data.
Notes for reviewers
The checker uses static and literal dynamic imports with explicit roots for dynamically discovered modules. Configuration-loaded packages have explicit dependencyReferences. It implements this repository's file, export, and dependency checks. Knip's framework-specific plugin discovery is replaced by this explicit configuration.
The local compatibility package implements the project-file interface of typescript-eslint 8.72.1. Review that consumer and its integration test when upgrading the parser.
Advisory