Repository navigation
fix: use stdenv.hostPlatform.isDarwin in comfy-kitchen override - #125
Open
Daniil-Makarov wants to merge 1 commit into
Open
Daniil-Makarov wants to merge 1 commit into
Daniil-Makarov wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comfy-kitchen override in
nix/vendored-packages.nixstill readspkgs.stdenv.isDarwin, which nixpkgs now deprecates, so everyevaluation that pulls in comfy-kitchen (including downstream NixOS
configs using the overlay) prints:
This moves the check to
stdenv.hostPlatform, reusing theuseDarwinArm64name fromnix/python-overrides.nix.No functional change:
packages.{x86_64-linux,aarch64-darwin}.defaultdrvPaths are identical before and after, evaluation passes with
--option abort-on-warn true, andnixfmt --checkis clean.🤖 Generated with Claude Code