Repository navigation
Set the view tree OnBackPressedDispatcherOwner in CoreAppCompatActivity - #666
Merged
Merged
Conversation
RibActivity attaches its root view to android.R.id.content without calling setContentView, so ComponentActivity.initializeViewTreeOwners() never runs. initViewTreeOwners() fills in the lifecycle, ViewModel store and saved-state owners, but not the OnBackPressedDispatcherOwner. findViewTreeOnBackPressed- DispatcherOwner() therefore returns null for every view in a RIB activity. View-based components that register back callbacks through the view tree (for example a bottom sheet that dismisses on back) silently skip registration. Under predictive back the key-event fallback never fires, so back reaches RibActivity's callback and the router navigates away instead of the component handling it. Add an explicit androidx.activity dependency to rib-android-core. That pulls in a newer lifecycle, where the ViewTreeLifecycleOwner and ViewTreeViewModelStoreOwner classes are no longer callable from Kotlin, so switch to the equivalent extension functions; the compiled calls are the same. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gpolak
commented
Oct 21, 2026
| window.decorView.setViewTreeLifecycleOwner(this) | ||
| window.decorView.setViewTreeViewModelStoreOwner(this) | ||
| window.decorView.setViewTreeSavedStateRegistryOwner(this) | ||
| window.decorView.setViewTreeOnBackPressedDispatcherOwner(this) |
Contributor
Author
There was a problem hiding this comment.
This line is the change - also register OnBackPressDispatcherOwner
psteiger
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RibActivity attaches its root view to android.R.id.content without calling setContentView, so ComponentActivity.initializeViewTreeOwners() never runs. initViewTreeOwners() fills in the lifecycle, ViewModel store and saved-state owners, but not the OnBackPressedDispatcherOwner. findViewTreeOnBackPressed- DispatcherOwner() therefore returns null for every view in a RIB activity.
View-based components that register back callbacks through the view tree (for example a bottom sheet that dismisses on back) silently skip registration. Under predictive back the key-event fallback never fires, so back reaches RibActivity's callback and the router navigates away instead of the component handling it.
Add an explicit androidx.activity dependency to rib-android-core. That pulls in a newer lifecycle, where the ViewTreeLifecycleOwner and ViewTreeViewModelStoreOwner classes are no longer callable from Kotlin, so switch to the equivalent extension functions; the compiled calls are the same.