Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When macOS isolated-browser discovery finds an installed browser but its signature verification fails, it currently discards the reason and returns only a generic unavailable refusal.
Preserve bounded, safe verification details for failed candidates: the fixed browser identifier, verification stage, diagnostic category and exit code. Keep looking for a trusted candidate and return diagnostics only when discovery fails. Raw command output, paths and certificate details never enter the response.
Related work
Fixes #7742.
This is a focused diagnostic correction using the existing optional refusal detail field. No SDK signatures, refusal codes, permission boundaries or trust requirements change; no RFC proposed.
Compatibility and risk
Validation
On macOS arm64, before syncing the subsequent main-branch release/packaging/docs changes:
cargo clippy --locked -p platform-macos --all-targets -- -D warningspassed.bin/ci --quick --no-install: 5 passed, 3 heavy checks skipped.security_prompt::tests::the_system_consent_labels_include_allow_and_dont_allowexpects the ASCII-apostropheDon't Allow, which is absent from this host's system labels (the curly-apostrophe form is present). Restoring the exact main baseline reproduced the same failure; restoring the candidate then passed all 34 focused tests again.vendor_requirement_not_satisfied, stagesignature_verification, exit code 3. No browser was altered or re-signed. This is a controlled negative check, not a natural damaged-installation end-to-end reproduction.Final head
00cc287cde822c0ff8a9a248c91145c7f353e55d, based on maindde4a4b64a:bin/ci --no-install: 6 checks passed, 1 failed, 1 skipped. Strict Clippy, formatting, headers, image refs and Windows cfg checks passed. The same system-consent-label test failed (819 passed, 1 failed, 13 ignored); both integration tests passed.libs/cua-driver/typescript/node_modulesis absent. Docs generators were not routed because docs dependencies are absent. No dependencies were installed for these checks.Contributor and release checks
no-releaselabel is applied. (Not applicable: user-visible Driver fix.)bin/ciis green and signed off (bin/ci --signoff).