Repository navigation
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm one of the djLint maintainers. A few things in the djlint plugin no longer match djLint:
djlint.tomland.djlint.tomlbesides.djlintrcandpyproject.toml(added in 1.36.0, so the known good 1.36.4 has them). They're now indirect_configs, sosuggest_if: config_presentalso suggests djlint for projects that use them..flake8,setup.cfgortox.ini, so they no longer invalidate its cache.pyproject.tomlstays.Riverside-Healthcare/djlinttodjlint/djLint. The plugin README and the main README link there, and the plugin README lists the languages added since (Liquid, Tera, Askama, Mako).Testing
The lint and fmt commands and the parse regex are unchanged, so the existing snapshots still apply. I checked the config file names against djLint's
settings.pyat v1.36.4 and on master. I didn't run the plugin test suite locally; CI runs it.