Skip to content

fix(editor): pick grouped primitives in the viewport - #4

Merged
topviewai merged 1 commit into
topviewai:mainfrom
gyx85542-dot:fix/viewport-grouped-pick
Oct 16, 2026
Merged

topviewai merged 1 commit into
topviewai:mainfrom
gyx85542-dot:fix/viewport-grouped-pick

Conversation

@gyx85542-dot

Copy link
Copy Markdown

Summary

  • Viewport click and marquee selection now include primitives that belong to a group.
  • Agent scenes parent visible meshes under groups that have no geometry, so the previous parentId filter made those models impossible to select except from the object list.
  • Clicking a grouped part selects that part. A regression test covers a mesh parented under a group whose transform is not identity.

Test plan

  • pnpm exec vitest run src/engine/interact/__tests__/pickerGroupedPrimitive.test.ts in editor/packages/builder
  • Rebuilt @topview/3d-builder and clicked a grouped primitive in Studio; the inspector selected that node and showed the gizmo
  • Click a grouped model and box-select several grouped parts in another agent scene

Agent scenes parent visible meshes under groups that have no geometry, so excluding those primitives made click and marquee selection miss them.

Co-authored-by: Cursor <cursoragent@cursor.com>
@topviewai
topviewai merged commit a0671f9 into topviewai:main Oct 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants