Repository navigation
Fix: parse null as None on custom format_description! serde implementations - #817
Merged
jhpratt merged 2 commits intoOct 15, 2026
Conversation
Member
|
Looks like the recursion limit is being hit during testing. I'm looking into options that wouldn't involve any changes to this PR, so you don't need to do anything at this point in time. |
jhpratt
force-pushed
the
fix-format-description-deserialize-flatten-null
branch
from
October 15, 2026 08:35
11360e6 to
1231fa6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #817 +/- ##
=====================================
Coverage 87.8% 87.8%
=====================================
Files 106 106
Lines 14411 14411
=====================================
Hits 12647 12647
Misses 1764 1764 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Rebased and made a minor formatting change (that rustfmt doesn't do). Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the exact same issue as #473, but for custom formats defined via
format_description!, while that PR only addressed the issue for well-known formats.