Repository navigation
ci: use a workflow dependency lockfile instead of vendored actions - #524
Merged
Merged
Conversation
Generate .github/workflows/actions.lock with gh actions-lock v0.4.0. The lockfile records the commits of all actions, including actions that composite actions call, so the workflows use readable tags again. Keep the inlined semantic-pull-request job from #519, because gh actions-lock does not lock reusable workflows from other repositories.
mojomex
self-requested a review
October 29, 2026 08:08
mojomex
approved these changes
Oct 29, 2026
mojomex
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed code changes, CI status and gh actions-lock --verify. LGTM!
Collaborator
|
@interimadd Thank you so much, I was looking for a nice solution like this. I'm 100% for it. |
interimadd
marked this pull request as ready for review
October 29, 2026 08:15
interimadd
enabled auto-merge (squash)
October 29, 2026 08:18
Merged
2 tasks done
interimadd
disabled auto-merge
October 30, 2026 06:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
This PR is a proposal for discussion. It replaces the workaround in #519 with a workflow dependency lockfile (
.github/workflows/actions.lock).The lockfile records the commit of each action, including the actions that composite actions call. GitHub Actions runs the recorded commits. Thus the organization policy for full-length commit SHAs is satisfied without vendored copies of upstream actions. Workflow lockfiles became generally available on 2026-10-28.
In tier4/driving_log_replayer_v2#429, the same approach passed the policy check for actions nested in composite actions (
actions/cache@v4inpre-commit/action,cspell-action@v9inspell-check).This PR has two commits:
.github/actions/colcon-buildand.github/actions/colcon-test, and uses the upstream actions again.gh actions-lockv0.4.0. The tool changes theuses:references from SHAs to exact tags (for exampleactions/checkout@v7.0.1).The other changes from #518 (
permissions,concurrency, and inputs passed throughenv) are not changed.Exception: semantic-pull-request
gh actions-lockdoes not lock reusable workflows from other repositories (limitation, github/gh-actions-lock#179). Thus this PR keeps the inlined job from #519 insemantic-pull-request.yaml.Behavior compared to #519
pre-commit-optionaluses the upstreamautoware-github-actions/pre-commitagain. Its autofix push step cannot push withcontents: read. If pre-commit finds no changes, the step does nothing. If pre-commit changes files, the job fails, but it fails in that case already.documentation.ymlusesactions/upload-pages-artifact@v3.0.1again. The lockfile locks its nestedactions/upload-artifact@v4.Review Procedure
gh actions-lock --verifylocally. The result must beAll 9 workflows valid. It shows a warning for theros:${{ matrix.rosdistro }}container image, because the lockfile cannot lock container images.Remarks
To update the lockfile, install the extension and run it:
Dependabot updates the lockfile entry in the same pull request when it updates an action.
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks