Repository navigation
fix(tests): move Pest.php imports to the top - #209
Merged
Merged
Conversation
…username column A pint run moved the use statements below the uses() / pest()->extend() calls, so DuskTestCase and TestCase resolved to the global namespace and every test run failed with 'The class DuskTestCase was not found'.
The per-process compiled view folder (storage/framework/views/test_N) isn't created before the first view compiles with laravel 13, so the first request in a worker 500s. The suite is ~120 tests so running it serially is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite has been failing on main since July with
The class DuskTestCase was not found.A pint run (
6efaa96) swapped the fully qualified class names intests/Pest.phpfor short ones, but theuseimports ended up at the bottom of the file, after theuses()/pest()->extend()calls that need them. PHP only applies imports to code after them, soDuskTestCaseandTestCaseresolved to the global namespace. Moved the imports to the top, pint is happy with it so the lint workflow shouldn't undo it again.Also made
EmailVerificationCodeTestset ausernamewhen the users table has that column, so it can run in apps like Wave that require one.