Repository navigation
fix(phylo): decode Gblocks stdout before regex match in run_gblocks - #862
Merged
Merged
Conversation
AbstractCommandline.run() returns raw bytes from Popen.communicate() on
Python 3 (jcvi.apps.base.Popen does not set text=True), so the str
pattern in re.sub() raises:
TypeError: cannot use a string pattern on a bytes-like object
Decode the captured stdout defensively before matching so
'python -m jcvi.apps.phylo build' works with Gblocks on Python 3.
tanghaibao
approved these changes
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
python -m jcvi.apps.phylo buildcrashes on Python 3 when Gblocks is enabled:Root cause
run_gblocks()applies astrregex tor, butrcomes fromAbstractCommandline.run()(injcvi/compara/ks.py), which returnsPopen(...).communicate(). Sincejcvi.apps.base.Popendoes not settext=True/universal_newlines,communicate()returnsbyteson Python 3 — a leftover from the Python 2 port. This is independent of the Gblocks version.Fix
Decode the captured stdout defensively before matching:
Verification
python -m py_compile src/jcvi/apps/phylo.pypassesGblocks alignment: 1234 positions (57 %)) asbytesnow parses toalignp = 57; thestrpassthrough branch also works.Note: the same bytes/str pattern exists in
jcvi/compara/ks.pyfind_synonymous()(e.read().find(...)on acommunicate()result), which will need a separate fix.