Repository navigation
fix(runtime): reuse SSR styles during hydration - #6965
Open
Elements2720 wants to merge 1 commit into
Open
Elements2720 wants to merge 1 commit into
Elements2720 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6947.
SSR style generation now:
SSR styles
-> add sty-id for every component stylesheet
-> client hydration finds existing sheet
-> reuse it once per scope
-> HMR remains allowed to replace stylesheet text
Changes:
Evidence
The full root Jest run was also attempted. In this environment it hit an unrelated existing failure in src/compiler/output-targets/dist-lazy/test/generate-lazy-module.spec.ts and later ran out of memory; the focused runtime suite passed independently (65 suites, 685 tests) before the final HMR-only test addition.
Merge Danger
Door: two-way
Blast Radius: runtime
The change is limited to runtime stylesheet registration/reuse and its tests. HMR remains explicitly covered, while hydration no longer mutates server stylesheet text.