Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,17 @@
"@splunk/react-toast-notifications": "^0.13.0",
"@splunk/react-ui": "5.15.0",
"@splunk/search-job": "^3.1.0",
"@splunk/splunk-utils": "^3.4.0",
"@splunk/splunk-utils": "^4.2.0",
"@splunk/themes": "^1.11.0",
"@splunk/ui-utils": "^1.14.1",
"@splunk/visualization-context": "^28.9.0",
"@testing-library/jest-dom": "^7.0.1",
"@testing-library/react": "^15.0.7",
"@vitejs/plugin-react": "^4.7.0",
"@vitest/coverage-istanbul": "^4.1.12",
"@vitejs/plugin-react": "^6.2.1",
"@vitest/coverage-istanbul": "^5.1.0",
"glob": "^14.0.2",
"immutability-helper": "^3.1.1",
"js-yaml": "^4.3.2",
"js-yaml": "^5.5.0",
"lodash": "^4.18.1",
"prop-types": "^15.8.1",
"react": "18.3.1",
Expand All @@ -61,23 +61,23 @@
"react-router-dom": "7.18.3",
"styled-components": "^5.3.11",
"uuid": "^14.0.2",
"vite": "^7.3.7",
"vite": "^8.3.6",
"vite-plugin-checker": "^0.14.5",
"vitest": "^4.1.12",
"vitest": "^5.1.0",
"zod": "^4.6.6"
},
"devDependencies": {
"@babel/core": "^7.29.7",
"@babel/eslint-parser": "^7.29.7",
"@babel/helper-plugin-utils": "^7.29.7",
"@babel/plugin-transform-runtime": "^7.29.7",
"@babel/preset-env": "^7.29.7",
"@babel/preset-react": "^7.29.7",
"@babel/core": "^8.1.0",
"@babel/eslint-parser": "^8.0.7",
"@babel/helper-plugin-utils": "^8.0.1",
"@babel/plugin-transform-runtime": "^8.0.6",
"@babel/preset-env": "^8.0.7",
"@babel/preset-react": "^8.0.1",
"@kickstartds/core": "^4.1.0",
"@kickstartds/storybook-addon-jsonschema": "^4.0.0",
"@rollup/plugin-commonjs": "^29.0.3",
"@splunk/babel-preset": "^4.0.0",
"@splunk/eslint-config": "^5.1.0",
"@splunk/eslint-config": "^6.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Migrate the ESLint configuration before adopting v6

Version 6 of @splunk/eslint-config targets the flat-config ESLint toolchain, but this project still runs ESLint 8.57 with ui/.eslintrc.cjs extending the legacy @splunk/eslint-config/browser-prettier entry. Consequently the yarn run lint step in .github/workflows/build-ui.yml:16-17 cannot load a compatible configuration; migrate the complete ESLint stack and config file together, or retain the 5.x preset.

AGENTS.md reference: AGENTS.md:L50-L50

Useful? React with 👍 / 👎.

"@storybook/addon-a11y": "^10.5.10",
"@storybook/addon-links": "^10.5.10",
"@storybook/builder-vite": "^10.5.10",
Expand All @@ -93,7 +93,7 @@
"@types/lodash": "^4.17.25",
"@types/node": "^20.17.24",
"@types/react": "^18.3.31",
"@types/react-dom": "^18.3.7",
"@types/react-dom": "^19.3.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep React DOM types aligned with React 18

@types/react-dom 19 declares a React 19 type peer, but this manifest still pins both the runtime (react/react-dom) and @types/react to 18. A clean npm install will reject this incompatible peer graph with ERESOLVE, and installs that proceed with Yarn leave the type checker using React 19 DOM declarations against React 18 types. Keep @types/react-dom on the 18.x line, or upgrade React, ReactDOM, and their type packages together.

Useful? React with 👍 / 👎.

"@types/styled-components": "^5.1.36",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
Expand All @@ -120,17 +120,17 @@
"jest-environment-jsdom": "^30.5.0",
"jest-fixed-jsdom": "^0.0.11",
"jest-image-snapshot": "^6.5.2",
"jsdom": "^30.0.1",
"msw": "^2.15.0",
"msw-storybook-addon": "^2.0.7",
"jsdom": "^31.0.0",
"msw": "^3.0.4",
"msw-storybook-addon": "^3.0.3",
"prettier": "^2.8.8",
"querystring-es3": "^0.2.1",
"rollup-plugin-license": "^3.7.1",
"storybook": "^10.5.10",
"style-loader": "^4.0.0",
"stylelint": "^14.16.1",
"ts-node": "^10.9.2",
"typescript": "^5.9.3",
"typescript": "^7.0.2",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep TypeScript 5 for the declaration build

When yarn build:lib runs—also during prepublishOnly—vite.lib.config.ts invokes vite-plugin-dts, whose unplugin-dts/@volar/typescript pipeline consumes the JavaScript TypeScript compiler API. The TypeScript 7 native package selected here provides the native compiler rather than that compatible API, so declaration generation fails before dist/lib can be published. This is separate from the peer-range issue already reported: the direct development dependency itself must remain on a compiler-API-compatible TypeScript release until the declaration tooling is migrated.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove baseUrl before enabling TypeScript 7

When either Vite build invokes vite-plugin-checker, it reads ui/tsconfig.app.json, which still sets baseUrl and relies on it for the @/* path mapping. TypeScript 7 no longer supports baseUrl and reports it as a hard configuration error, so the native checker fails even independently of the already-reported declaration-tooling incompatibility. Remove baseUrl and make the mapping explicitly relative (for example, "./src/*"), or retain the earlier TypeScript release.

AGENTS.md reference: AGENTS.md:L18-L18

Useful? React with 👍 / 👎.

"undici": "^5.29.0",
"url": "^0.11.4",
"vite-plugin-dts": "5.0.3",
Expand All @@ -141,10 +141,10 @@
"react-dom": "^18.3.1",
"react-is": "^19.2.8",
"styled-components": "^5.3.11",
"typescript": "^5.9.3"
"typescript": "^7.0.2"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve support for the documented TypeScript toolchain

Changing the published peer dependency to ^7.0.2 makes npm peer resolution reject consumers that still use TypeScript 5, including the custom-UI setups documented in docs/custom_ui_extensions/context/custom_project_init.md and custom_test_ui_command.md, which specify TypeScript ^5.8.2. Because the package remains on version 6.6.0 and can be published with only a prerelease bump, existing 6.x consumers can encounter ERESOLVE during installation without opting into a major framework release; retain or widen the TypeScript peer range unless dropping TypeScript 5 is released as a breaking change.

Useful? React with 👍 / 👎.

},
"resolutions": {
"nanoid": "3.3.18",
"nanoid": "6.0.2",
"jest-runtime": "30.4.2",
"@npmcli/git": "^2.1.0",
"@types/react": "^18.3.31",
Expand All @@ -159,8 +159,8 @@
"esbuild": "^0.28.2",
"axios": "^1.20.0",
"jspdf": "^4.2.1",
"http-proxy-middleware": "^3.0.7",
"js-yaml": "^4.3.2",
"http-proxy-middleware": "^4.2.1",
"js-yaml": "^5.5.0",
"@splunk/react-ui": "5.15.0",
"@splunk/dashboard-event-handlers": "29.9.0",
"@splunk/dashboard-inputs": "29.9.0",
Expand All @@ -181,12 +181,12 @@
"@splunk/dashboard-types/ajv": "^8.20.0",
"table/ajv": "^8.20.0",
"@rushstack/node-core-library/ajv": "^8.20.0",
"diff": "^8.0.4",
"diff": "^9.0.0",
"crypto-js": "^4.2.0",
"vitest/vite": "^7.3.7",
"vitest/vite": "^8.3.6",
"lodash": "^4.18.1",
"protocol-buffers-schema": "^3.6.1",
"fast-uri": "^3.1.8",
"fast-uri": "^4.2.3",
"@xmldom/xmldom": "^0.9.12",
"jsonata": "^2.2.2",
"dompurify": "^3.4.16",
Expand Down
Loading
Loading