Skip to content

feat(discover): navigate loaded results from details - #287

Closed
snapetech wants to merge 1 commit into
mainfrom
codex/upstream-discover-detail-navigation-20261013
Closed

snapetech wants to merge 1 commit into
mainfrom
codex/upstream-discover-detail-navigation-20261013

Conversation

@snapetech

@snapetech snapetech commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Add previous and next controls to movie and series details when opened from a loaded Discover result list. Navigation follows the visible filtered order, including blocklist filtering, across movie and TV Discover pages, upcoming lists, public TMDB lists, and the Discover watchlist.

The SeerrNG design keeps the ordered media identities in a bounded tab-local sessionStorage context. The URL carries only an opaque context ID. Direct detail links stay unchanged and show no navigation controls. Context survives dynamic route transitions, manager-query cleanup, and browser history.

AI assistance: OpenAI Codex assisted with implementation, regression coverage, and release-note drafting under maintainer direction.

How Has This Been Tested?

  • Focused Vitest — 7/7 passed.
  • pnpm typecheck:client, focused ESLint and Oxlint, pnpm i18n:check, attribution check, current-batch/UI-style check, and scoped Prettier — passed.
  • Focused provider-stubbed Cypress movie and series navigation flows — both passed in isolated runs; only the feature tests were selected so unrelated existing Discover specs could not contact providers. The temporary test selector was removed before commit.
  • pnpm cypress:build passed during implementation; Hosted Mode 2 will validate the exact committed head.
  • pnpm release-notes:preview --base origin/main --head HEAD and git diff --check — passed.
  • Whole-repository pnpm format:check still reports two unchanged files (bin/engine-workflow-triggers.test.mjs and scripts/check-workflow-boundaries.test.mjs); all files changed in this PR pass the scoped check.

Visual inspection: The detail action row and navigation controls were reviewed at desktop and 390px widths. The next control is absent at the last result. Captures use mocked title metadata and are not committed.

No live TMDB/Plex round trip was run. The focused browser tests stub title/detail APIs and use a proxy guard; unrelated fixture avatar requests were refused by that guard. Hosted Mode 2 validation is pending against this exact PR head.

Release Notes

  • I added a release-note fragment under release-notes/.
  • This change is internal-only and does not need a user-facing release note.
  • The fragment includes audience, area, action, and breaking-change status.
  • I previewed the release text with pnpm release-notes:preview.

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed AI use and its scope.
  • A release-note fragment is included; the README/review index and fork-retirement matrix are tracked in PR docs: index upstream review and fork retirement criteria #257.
  • Hosted Mode 2 has passed; it is pending against this PR head.
  • No database migration or translation-key change is required.

@github-actions

Copy link
Copy Markdown

Hey @snapetech, thanks for submitting this PR! However, it looks like the PR template hasn't been fully filled out.

Issues found:

  • Checklist section is missing or has been removed.
  • The contribution guidelines checkbox has not been checked.

Please update your PR description to follow the PR template.
Incomplete PR descriptions may be closed when required information is missing.
See our Contributing Guide for more details.

This check will automatically re-run when you edit your PR description.

@snapetech snapetech closed this Oct 15, 2026
@snapetech
snapetech deleted the codex/upstream-discover-detail-navigation-20261013 branch October 15, 2026 14:53
@snapetech

Copy link
Copy Markdown
Collaborator Author

Resolution audit: superseded by implementation on main. Source/successor commit is an ancestor of main.

Recorded source resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant