Skip to content

fix(webpush): preserve subscriptions across devices - #284

Merged
snapetech merged 2 commits into
mainfrom
codex/upstream-webpush-device-isolation-20261014
Oct 15, 2026
Merged

snapetech merged 2 commits into
mainfrom
codex/upstream-webpush-device-isolation-20261014

Conversation

@snapetech

Copy link
Copy Markdown
Collaborator

Description

Fix Web Push registration so two devices with the same browser signature keep independent subscriptions. Registration now identifies an existing record by endpoint, then removes stale endpoints only when the subscription auth key matches for the same user. This also lets endpoint rotation complete when the browser user-agent changes.

This is a focused SeerrNG adaptation of upstream Seerr issue #2660 and PR #3142. SeerrNG already clears the current user's browser subscription on logout, so this change does not repeat that part of the upstream PR.

How Has This Been Tested?

  • pnpm test:node server/routes/user.test.ts — 107 passed, 0 failed, 0 skipped. This includes regressions for same-user-agent sibling devices and auth-matched endpoint rotation across user-agent changes.
  • pnpm typecheck:server — passed.
  • ESLint, Oxlint, Prettier, attribution hook, diff check, and release-note preview — passed.
  • pnpm build, the full repository suite, and a live browser push round-trip were not run.
  • No migration or translation key change is needed.

Release Notes

  • I added a release-note fragment under release-notes/.
  • This change is internal-only and does not need a user-facing release note.
  • The fragment includes audience, area, action, and breaking-change status.
  • I previewed the release text with pnpm release-notes:preview.

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy).
  • I have updated the documentation accordingly (release note; review index and retirement matrix are tracked in PR docs: index upstream review and fork retirement criteria #257).
  • All focused new and existing route tests passed.
  • Successful build pnpm build.
  • Translation keys pnpm i18n:extract (no translation strings changed).
  • Database migration (not required).

AI assistance: OpenAI Codex assisted implementation, regression tests, and release-note drafting under maintainer direction.

@snapetech
snapetech marked this pull request as ready for review October 15, 2026 13:30
@snapetech
snapetech merged commit ce0f27d into main Oct 15, 2026
30 checks passed
@snapetech
snapetech deleted the codex/upstream-webpush-device-isolation-20261014 branch October 15, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant