Repository navigation
fix(webpush): preserve subscriptions across devices - #284
Merged
snapetech merged 2 commits intoOct 15, 2026
Merged
Conversation
9 of 11 tasks
snapetech
marked this pull request as ready for review
October 15, 2026 13:30
snapetech
deleted the
codex/upstream-webpush-device-isolation-20261014
branch
October 15, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Web Push registration so two devices with the same browser signature keep independent subscriptions. Registration now identifies an existing record by endpoint, then removes stale endpoints only when the subscription auth key matches for the same user. This also lets endpoint rotation complete when the browser user-agent changes.
This is a focused SeerrNG adaptation of upstream Seerr issue #2660 and PR #3142. SeerrNG already clears the current user's browser subscription on logout, so this change does not repeat that part of the upstream PR.
How Has This Been Tested?
pnpm test:node server/routes/user.test.ts— 107 passed, 0 failed, 0 skipped. This includes regressions for same-user-agent sibling devices and auth-matched endpoint rotation across user-agent changes.pnpm typecheck:server— passed.pnpm build, the full repository suite, and a live browser push round-trip were not run.Release Notes
release-notes/.pnpm release-notes:preview.Checklist:
pnpm build.pnpm i18n:extract(no translation strings changed).AI assistance: OpenAI Codex assisted implementation, regression tests, and release-note drafting under maintainer direction.