Repository navigation
chore(qa): run the visual QA suites in every interface locale - #437
Merged
Merged
Conversation
The suites matched English button text, messages and aria-labels, so a
pass under KINDLING_LOCALE stopped at the first English wait. The harness
now loads the app's i18n module and maps the English copy the suites use,
including one-placeholder templates such as "Close {name}", to the running
locale; the runner rewrites English aria-label, title and placeholder
selectors the same way. English runs are unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The visual QA suites matched English button text, messages and aria-labels, so a pass started with
KINDLING_LOCALE=<tag>stopped at the first English wait (about 12 seconds in). With this change, all five non-English locales complete the full 147-checkpoint matrix.harness.js): on install, loads the app's own i18n module (same module instance, same locale) and indexes the English catalog.q.L/q.Ls/q.has/q.ismap the English copy a suite uses to the running locale. One-placeholder templates such as "Close {name}" are handled recursively.q.templatebuilds prefix/suffix selectors for templated labels such as "Shortcut for {label}" (zh-CN puts the label first).run.mjs):localize()rewrites Englisharia-label/title/placeholderselectors in any page code it sends. It handles plain or escaped quotes and asks the page once for labels outside the catalog.tr()covers values the runner types. Button lookup goes throughq.is.window.__qa.has/is. The "Project: N words" wait uses the catalog key.English runs are unchanged. The full matrix reports the same changed checkpoints as before this branch: the suite 07 toolbar row, fixed separately in #436, and the timing-dependent 19-02 export preview.
Results from the first all-locale pass on main (64a068a)
All five non-English locales ran all 147 checkpoints. Axe, Press, overflow and console audits were clean in every locale. Every image differs from the English baselines, as expected. A review of the captures found the defects to fix in follow-ups:
revisions.ts)exportPrototype.ts)project_typein the copy-references dialog.toLowerCase()on type labels breaks German nouns, and hedge templates built by concatenation read badly («Novo(a) capítulo», «Новый(-ая) глава»).Test plan
npm run test:qa-harness: 34 passed, including new tests for the page helpers andRunner.localize/trnpm run qa:visual: English full matrix, 138/147 matched; the 9 changed are the known 07 and 19-02 diffsKINDLING_LOCALE=<tag> npm run qa:visualfor zh-CN, es, pt-BR, ru and de: full matrix, audits clean, cleanup succeedednpm run format:check🤖 Generated with Claude Code