Skip to content

chore(deps): clear cargo audit failures in quinn-proto, rustls and zip - #411

Merged
smith-and-web merged 2 commits into
mainfrom
fix/cargo-audit-advisories
Oct 18, 2026
Merged

smith-and-web merged 2 commits into
mainfrom
fix/cargo-audit-advisories

Conversation

@smith-and-web

Copy link
Copy Markdown
Owner

Why

The Cargo Security Audit job fails on main (the scheduled Security run failed on 2026-10-12) and on every PR, including #410. New RustSec advisories were published against the current Cargo.lock; none of this is caused by any one PR.

What

  • quinn-proto 0.11.15 -> 0.11.19 (RUSTSEC-2026-0338..0342) and rustls 0.23.45 -> 0.23.46 (RUSTSEC-2026-0346..0349), via cargo update -p. quinn-proto 0.11.19 pulls rand 0.10, which accounts for most of the other lockfile churn.
  • Direct zip 8 -> 9 (9.0.5), the fix for RUSTSEC-2026-0367/0368/0369. zip 9 makes ZipFile::name() return a Result, so the four test call sites unwrap it. No non-test code changed. Its new dependencies (digest, sha1/sha2 0.11 and friends) account for the rest of the lockfile churn.
  • Two older zip copies remain, via docx-rs 0.4 (zip 0.6.6) and tauri-plugin-updater (zip 4.6.1). Neither can move to 9 yet (docx-rs 0.4.22 still needs zip 8.x). All three advisories are in the extract APIs, which kindling never calls on docx-rs (it only writes DOCX) and which the updater reaches only for the legacy Windows .zip bundle after the minisign signature check. Ignored in src-tauri/.cargo/audit.toml with that reasoning and a note to remove them when upstream catches up.

Verified

  • cargo audit exits 0 locally.
  • cargo fmt --all -- --check and cargo clippy --all-targets --all-features -- -D warnings are clean.

Not verified

  • cargo test --all-features did not finish locally (cold build on a slow machine), so CI is the first test run. The only code touched is test code, plus the zip 9 bump in export paths that CI's tests exercise (EPUB and DOCX export).
  • Pushed with SKIP_PREPUSH=1 for the same reason.

🤖 Generated with Claude Code

smith-and-web and others added 2 commits October 17, 2026 22:03
Update quinn-proto to 0.11.19 and rustls to 0.23.46, and move the direct
zip dependency to 9.x. zip 9 makes ZipFile::name() return a Result, so the
test code that reads entry names now unwraps it.

Two older zip copies remain, via docx-rs and tauri-plugin-updater, and
neither can move to 9.x yet. The three zip advisories only affect the
extract APIs, which neither path reaches, so they are ignored in
audit.toml with the reasoning recorded there.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@smith-and-web
smith-and-web merged commit d656817 into main Oct 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant