Repository navigation
chore(deps): clear cargo audit failures in quinn-proto, rustls and zip - #411
Merged
Merged
Conversation
Update quinn-proto to 0.11.19 and rustls to 0.23.46, and move the direct zip dependency to 9.x. zip 9 makes ZipFile::name() return a Result, so the test code that reads entry names now unwraps it. Two older zip copies remain, via docx-rs and tauri-plugin-updater, and neither can move to 9.x yet. The three zip advisories only affect the extract APIs, which neither path reaches, so they are ignored in audit.toml with the reasoning recorded there. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
Cargo Security Auditjob fails on main (the scheduled Security run failed on 2026-10-12) and on every PR, including #410. New RustSec advisories were published against the currentCargo.lock; none of this is caused by any one PR.What
quinn-proto0.11.15 -> 0.11.19 (RUSTSEC-2026-0338..0342) andrustls0.23.45 -> 0.23.46 (RUSTSEC-2026-0346..0349), viacargo update -p. quinn-proto 0.11.19 pullsrand0.10, which accounts for most of the other lockfile churn.zip8->9(9.0.5), the fix for RUSTSEC-2026-0367/0368/0369. zip 9 makesZipFile::name()return aResult, so the four test call sites unwrap it. No non-test code changed. Its new dependencies (digest, sha1/sha2 0.11 and friends) account for the rest of the lockfile churn.zipcopies remain, viadocx-rs0.4 (zip 0.6.6) andtauri-plugin-updater(zip 4.6.1). Neither can move to 9 yet (docx-rs 0.4.22 still needs zip 8.x). All three advisories are in theextractAPIs, which kindling never calls on docx-rs (it only writes DOCX) and which the updater reaches only for the legacy Windows .zip bundle after the minisign signature check. Ignored insrc-tauri/.cargo/audit.tomlwith that reasoning and a note to remove them when upstream catches up.Verified
cargo auditexits 0 locally.cargo fmt --all -- --checkandcargo clippy --all-targets --all-features -- -D warningsare clean.Not verified
cargo test --all-featuresdid not finish locally (cold build on a slow machine), so CI is the first test run. The only code touched is test code, plus the zip 9 bump in export paths that CI's tests exercise (EPUB and DOCX export).SKIP_PREPUSH=1for the same reason.🤖 Generated with Claude Code