Repository navigation
clens-011-fmtduration-hours: fmtDuration never renders hours — a 2h session prints "120m" - #20
Merged
Merged
Conversation
…rs-1784805064990)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clens-011-fmtduration-hours
Ticket: tickets/clens-011-fmtduration-hours.md
Added the minimal
hours = Math.floor(minutes / 60)rollover at the ≥60-minute boundary, mirroring the siblingformatDurationinutils.ts. Sub-hour/sub-minute paths are untouched (same code path, same output). The regression test written earlier (packages/cli/test/format-helpers.test.ts) now passes, and no other test, lint, or typecheck regressed. Changes are left uncommitted in the working tree as instructed.Gates
lint — pass
typecheck — pass
test — pass
Gate suite ran in: 19193ms
Repair rounds used: 0
Total duration: 239114ms
Run id: clens-011-fmtduration-hours-1784805064990
Captured sessions
/Users/silouane/adw-factory/runs/clens-011-fmtduration-hours-1784805064990/.clens/sessions/0a5e4fdd-e125-45ae-948d-af68381f3559.jsonl(capture incomplete: session file missing after clens-hook exit 0: /Users/silouane/adw-factory/runs/clens-011-fmtduration-hours-1784805064990/.clens/sessions/0a5e4fdd-e125-45ae-948d-af68381f3559.jsonl)/Users/silouane/adw-factory/runs/clens-011-fmtduration-hours-1784805064990/.clens/sessions/d486e9d6-726f-4d15-b0a8-2b0d2b12f147.jsonl(capture incomplete: session file missing after clens-hook exit 0: /Users/silouane/adw-factory/runs/clens-011-fmtduration-hours-1784805064990/.clens/sessions/d486e9d6-726f-4d15-b0a8-2b0d2b12f147.jsonl)Opened by adw-factory. A human reviews and merges — the factory never merges,
approves, or closes its own pull requests.