Repository navigation
Ignore pages during NewRepository - #309
Merged
Merged
Conversation
This seems to be required after sigstore#301 that started using github.NewRepositoryPages. * we never set .Pages on github.NewRepository anymore * Adding IgnoreChanges([]string{"pages"}) ensures Repository never tries to call DELETE /repos/.../pages on the repos that still have a "pages" block in their Repository state * Actual Pages changes are now detected and applied by github.NewRepositoryPages Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Hayden-IO
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be required after #301 that started using
github.NewRepositoryPagesto manage pages.github.NewRepositoryanymore (and the field is now deprecated)IgnoreChanges([]string{"pages"})ensures Repository never tries to call DELETE /repos/.../pages on the repos that still have a "pages" block in their Repository stategithub.NewRepositoryPagesI came up with this because sigstore/community#755 includes "pages" block removals in pulumi preview (unrelated to the PR changes -- they are a result of #301 as far as I can tell) and I believe it should not.